Remove unused MSBuildBinLogQuery and dotnet-bootstrapper projects#441
Open
marcpopMSFT wants to merge 1 commit into
Open
Remove unused MSBuildBinLogQuery and dotnet-bootstrapper projects#441marcpopMSFT wants to merge 1 commit into
marcpopMSFT wants to merge 1 commit into
Conversation
Remove src/MSBuildBinLogQuery, src/dotnet-bootstrapper, and their corresponding test projects. These are not part of the uninstall tool release and are unused. The core-sdk-tasks project is retained as it is required by the redist project for MSI packaging. Also remove the MSBuildBinLogQuery section from README.md and clean up the solution file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes two unused/never-shipped tool projects (MSBuildBinLogQuery and dotnet-bootstrapper) from the repository, and updates the solution/docs accordingly to focus the repo on the dotnet-core-uninstall tool and its packaging.
Changes:
- Deleted the
src/MSBuildBinLogQuerytool andtest/MSBuildBinLogQuery.Teststest project. - Deleted the
src/dotnet-bootstrappertool andtest/dotnet-bootstrapper.Teststest project (including localization assets). - Cleaned up
lab.slnand the rootREADME.mdto remove references to the removed tools.
Reviewed changes
Copilot reviewed 92 out of 92 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes the MSBuildBinLogQuery section from the root README. |
| lab.sln | Removes MSBuildBinLogQuery project entries/configs from the solution. |
| src/dotnet-core-uninstall/LocalizableStrings.resx.bak | Adds a .bak resource file (appears unintended). |
| src/MSBuildBinLogQuery/Ast/AstNodeWithConstraints.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/ComponentNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/ConstraintNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/ErrorNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/IAstNode.cs | Deletes MSBuildBinLogQuery AST interfaces. |
| src/MSBuildBinLogQuery/Ast/IdNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/IFilterable.cs | Deletes MSBuildBinLogQuery AST interfaces. |
| src/MSBuildBinLogQuery/Ast/LogNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/LogNodeType.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/MessageNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/NameNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/PathNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/ProjectNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/TargetNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/TaskNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Ast/WarningNode.cs | Deletes MSBuildBinLogQuery AST implementation. |
| src/MSBuildBinLogQuery/Construction/BinaryLogReader.cs | Deletes MSBuildBinLogQuery binlog reader. |
| src/MSBuildBinLogQuery/Construction/GraphBuilder.cs | Deletes MSBuildBinLogQuery graph builder. |
| src/MSBuildBinLogQuery/Graph/DirectedAcyclicGraph.cs | Deletes MSBuildBinLogQuery graph utilities. |
| src/MSBuildBinLogQuery/Graph/IDirectedAcyclicGraphNode.cs | Deletes MSBuildBinLogQuery graph interfaces. |
| src/MSBuildBinLogQuery/Graph/IShallowCopyableGraphNode.cs | Deletes MSBuildBinLogQuery graph interfaces. |
| src/MSBuildBinLogQuery/Graph/ProjectNode_BeforeThis.cs | Deletes MSBuildBinLogQuery graph node type. |
| src/MSBuildBinLogQuery/Graph/TargetNode_AfterThis.cs | Deletes MSBuildBinLogQuery graph node type. |
| src/MSBuildBinLogQuery/Graph/TargetNode_BeforeThis.cs | Deletes MSBuildBinLogQuery graph node type. |
| src/MSBuildBinLogQuery/Interpret/Interpreter.cs | Deletes MSBuildBinLogQuery interpreter. |
| src/MSBuildBinLogQuery/MSBuildBinLogQuery.csproj | Deletes MSBuildBinLogQuery project file. |
| src/MSBuildBinLogQuery/Parse/ParseException.cs | Deletes MSBuildBinLogQuery parser exception type. |
| src/MSBuildBinLogQuery/Parse/Parser.cs | Deletes MSBuildBinLogQuery parser. |
| src/MSBuildBinLogQuery/Result/Build.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Component.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Error.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/IQueryResult.cs | Deletes MSBuildBinLogQuery result model interfaces. |
| src/MSBuildBinLogQuery/Result/IResultWithId.cs | Deletes MSBuildBinLogQuery result model interfaces. |
| src/MSBuildBinLogQuery/Result/IResultWithName.cs | Deletes MSBuildBinLogQuery result model interfaces. |
| src/MSBuildBinLogQuery/Result/IResultWithPath.cs | Deletes MSBuildBinLogQuery result model interfaces. |
| src/MSBuildBinLogQuery/Result/Log.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Message.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Project.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Target.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Task.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Result/Warning.cs | Deletes MSBuildBinLogQuery result model. |
| src/MSBuildBinLogQuery/Scan/ScanException.cs | Deletes MSBuildBinLogQuery scanner exception type. |
| src/MSBuildBinLogQuery/Scan/Scanner.cs | Deletes MSBuildBinLogQuery scanner. |
| src/MSBuildBinLogQuery/Token/CommaToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/DoubleSlashToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/EofToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/EqualToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/ErrorToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/IdToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/IntegerToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/LeftBracketToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/MessageToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/NameToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/PathToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/ProjectToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/RightBracketToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/SingleSlashToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/StringToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/TargetToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/TaskToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Token/Token.cs | Deletes MSBuildBinLogQuery token base type. |
| src/MSBuildBinLogQuery/Token/WarningToken.cs | Deletes MSBuildBinLogQuery token types. |
| src/MSBuildBinLogQuery/Utility/ItemManager.cs | Deletes MSBuildBinLogQuery utilities. |
| src/MSBuildBinLogQuery/Utility/PropertyManager.cs | Deletes MSBuildBinLogQuery utilities. |
| src/dotnet-bootstrapper/BootstrapperCommandParser.cs | Deletes dotnet-bootstrapper CLI parser. |
| src/dotnet-bootstrapper/LocalizableStrings.resx | Deletes dotnet-bootstrapper resources. |
| src/dotnet-bootstrapper/Program.cs | Deletes dotnet-bootstrapper entrypoint. |
| src/dotnet-bootstrapper/README.md | Deletes dotnet-bootstrapper README. |
| src/dotnet-bootstrapper/dotnet-bootstrapper.csproj | Deletes dotnet-bootstrapper project file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.cs.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.de.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.es.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.fr.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.it.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.ja.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.ko.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.pl.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.pt-BR.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.ru.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.tr.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.zh-Hans.xlf | Deletes dotnet-bootstrapper localization file. |
| src/dotnet-bootstrapper/xlf/LocalizableStrings.zh-Hant.xlf | Deletes dotnet-bootstrapper localization file. |
| test/MSBuildBinLogQuery.Tests/Interpret/InterpreterTests.cs | Deletes MSBuildBinLogQuery tests. |
| test/MSBuildBinLogQuery.Tests/MSBuildBinLogQuery.Tests.csproj | Deletes MSBuildBinLogQuery test project file. |
| test/MSBuildBinLogQuery.Tests/Parse/ParserTests.cs | Deletes MSBuildBinLogQuery tests. |
| test/MSBuildBinLogQuery.Tests/Scan/ScannerTests.cs | Deletes MSBuildBinLogQuery tests. |
| test/dotnet-bootstrapper.Tests/EndToEndTests.cs | Deletes dotnet-bootstrapper tests. |
| test/dotnet-bootstrapper.Tests/TestUtilities.cs | Deletes dotnet-bootstrapper test utilities. |
| test/dotnet-bootstrapper.Tests/dotnet-bootstrapper.Tests.csproj | Deletes dotnet-bootstrapper test project file. |
Comments suppressed due to low confidence (1)
src/dotnet-core-uninstall/LocalizableStrings.resx.bak:414
LocalizableStrings.resx.baklooks like an accidental backup artifact. It is also not well-formed XML because it has non-XML content after the closing</root>tag (the timestamp lines), which can confuse tooling and should not live undersrc/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused projects that are not part of the uninstall tool release:
What's kept
Validation
dotnet build lab.sln /p:RID=win-x86succeeds including MSI generation