Remove symbol server PATs from publish-logs.yml redaction list [release/10.0]#16869
Open
missymessa wants to merge 2 commits into
Open
Remove symbol server PATs from publish-logs.yml redaction list [release/10.0]#16869missymessa wants to merge 2 commits into
missymessa wants to merge 2 commits into
Conversation
Remove microsoft-symbol-server-pat, symweb-symbol-server-pat, and dnceng-symbol-server-pat from the binlog redaction list. These PATs are no longer used for symbol upload authentication since PR #16688 migrated to DefaultIdentityTokenCredential (Entra auth). Relates to: dnceng/internal#10150, dnceng/internal#10148, dnceng/internal#10149
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Arcade publishing log-redaction step on release/10.0 by removing symbol server PAT variables from the binlog redaction list in eng/common/core-templates/steps/publish-logs.yml, based on a migration toward Entra (DefaultIdentityTokenCredential) authentication for symbol upload.
Changes:
- Removed
microsoft-symbol-server-patfrom the redaction arguments list. - Removed
symweb-symbol-server-patfrom the redaction arguments list. - Removed
dnceng-symbol-server-patfrom the redaction arguments list.
| '$(microsoft-symbol-server-pat)' | ||
| '$(symweb-symbol-server-pat)' | ||
| '$(dnceng-symbol-server-pat)' | ||
| '$(dn-bot-all-orgs-build-rw-code-rw)' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all three symbol server PAT entries from the binlog redaction list in
eng/common/core-templates/steps/publish-logs.ymlon therelease/10.0branch.Motivation
PR #16688 (merged to main May 12, 2026) migrated symbol upload authentication from PAT-based auth to
DefaultIdentityTokenCredential(Entra). The code fallback is already present on release/10.0. These PATs are no longer functionally needed and can be removed from the redaction list.Changes
microsoft-symbol-server-patfrom redaction argumentssymweb-symbol-server-patfrom redaction argumentsdnceng-symbol-server-patfrom redaction argumentsRelated