warn on duplicate cache-to targets#3833
Conversation
|
weird. the dco is failing although the commits are signed 🤔 let me try something. |
d6b052c to
0f098db
Compare
|
ping! @crazy-max |
tonistiigi
left a comment
There was a problem hiding this comment.
If added, this should be based on some primary values, eg. type=local,dest=, type=registry,ref=. Eg. if same ref is used with different mode then it is still a collision. And we shouldn't use the potentially secret values for comparison or log them anyway.
Does this work with target inheritance?
yea sure, i think using a helper func here is enough for comparing the destination key. creds/mode are ignored
yes, this runs after inheritance gets resolved so shared inherited cache-to values still trigger the warning |
Signed-off-by: Areeb Ahmed <areebahmed0709@gmail.com>
0f098db to
6bb0e59
Compare
summary
closes #3819
ai model disclosure
used vscode copilot (claude sonnet 4.6) to understand the issue context and help generate a fix. changes were self-reviewed and verified via: