Fix potential typo issue in RSTAB Python Client#42
Open
vemlor-bot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
ResultTablesmethods call SOAP operations with a misspelled name:get_results_for_efeective_lengths_and_critical_loads_by_eigenvectorget_results_for_efeective_lengths_and_critical_loads_by_memberThe RSTAB WebService contract spells these
..._effective_...(seeIRstabModel.csin Dlubal_CSharp_Client):So the misspelled client calls target SOAP operations that don't exist — both methods fail at runtime for anyone who calls them. This corrects the spelling to match the service contract; no behaviour change beyond making the two methods reachable.
Closes #40
Opened by Vemlor. We watch public CI, prep the fix, and send it as a ready-to-merge PR. Fully automated and unsolicited; close it with no hard feelings if you'd rather not. Happy to adjust anything.