#1255: Enhance snapshot version recognition in IDEasy#1962
Conversation
…ducing isSameSnapshotVersion
Coverage Report for CI Build 26654875090Coverage decreased (-0.01%) to 71.09%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions69 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
left a comment
There was a problem hiding this comment.
@AdemZarrouki thanks for your PR and sorry for stepping in early. I just found some time to have a look already and want to give fast feedback...
Your approach looks good and your test with overriding the methods in anonymous class is very elegant to properly test the logic. 👍
For the regex stuff I left some suggestion to improve.
|
@hohwille thanks for the early review and the improvements you mentioned. I updated the PR with the requested changes and also i think that using two REGEX constants is easier to understand. |
|
Local build testing: GraalVM testing: After some discussion with @AdemZarrouki, it seems like there's some difficulty in testing the actual behavior of this fix, given that both local as well as the GraalVM build do not use the same naming format as in real life testing. |
|
@laert-ll Thanks for the review and test. So the steps are:
|
There was a problem hiding this comment.
@AdemZarrouki thanks for the improvements. IMHO now better to read, understand, and maintain. I also like that you added the constants for the group numbers that improve readability while the group numbers are close to the REGEX declarations now and therefore also way easier to update in case the REGEX ever needs to be changed. Great job 👍
Ready for merge.
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
This PR fixes #1255
Implemented changes:
isSameSnapshotVersionto compare 2 snapshot versionscheckIfUpdateIsAvailablewith explicit snapshot vs stable version comparison logicTesting instructions
testCheckIfUpdateIsAvailableWithSameSnapshotVersionsandtestCheckIfUpdateIsAvailableWithDifferentSnapshotVersions."C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ideasy.exe"status you get only2026.05.001-SNAPSHOTso we can't really compare it with the latest version (here2026.05.001-20260520.032326-18)Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal