feat: document external-group source on group listing responses#1620
feat: document external-group source on group listing responses#1620dorsha wants to merge 1 commit into
Conversation
Group listing responses (load_all_groups / _for_members / _group_members, sync
and async) now carry a `source` field ("scim" | "jit") distinguishing
SCIM-provisioned groups from JIT (SSO SAML/OIDC assertion) groups. Responses are
dicts, so the field passes through automatically; document it in the response
shape. Mirrors the go-sdk change.
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment focuses on covering both synchronous and asynchronous group management modules, with contributors selected based on their specific file contributions to ensure thorough review of the new 'source' field implementation in group responses.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Documents a new source field ("scim" | "jit") in the group-listing response docstrings for both sync and async clients.
No issues found — good bones! Pure docstring change, consistent across all three methods and both files. Woof!
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
1 participant
What
Group listing responses (
load_all_groups/load_all_groups_for_members/load_all_group_members, sync and async) now carry asourcefield ("scim"|"jit") distinguishing SCIM-provisioned groups from JIT (SSO SAML/OIDC assertion) groups. Responses are dicts, so the field passes through automatically — this documents it in the response shape.Why
Backend now persists JIT (SSO assertion) groups as external groups so the
{{user.idpGroups}}claim survives token refresh, and the management group API exposes their origin via a newsourcefield. This mirrors the equivalent go-sdk / node-sdk changes so all SDKs surface it.Related
feat/external-group-source(Group.Source)🤖 Generated with Claude Code