Skip to content

🧪 Add tests for GET /api/export-excel#6

Open
deitaur wants to merge 1 commit into
masterfrom
feat/test-export-excel-3871311524714203752
Open

🧪 Add tests for GET /api/export-excel#6
deitaur wants to merge 1 commit into
masterfrom
feat/test-export-excel-3871311524714203752

Conversation

@deitaur
Copy link
Copy Markdown
Owner

@deitaur deitaur commented May 29, 2026

🎯 What: The testing gap addressed
The GET /api/export-excel endpoint lacked testing for its complex stream response containing an Excel file.

📊 Coverage: What scenarios are now tested

  • Happy Path: Correct generation of an Excel file with expected rows, columns, and data mapped from a mocked database structure (2-level deep validation parsing actual binary buffer).
  • Error Edge Case: Endpoint properly captures errors (such as DB failures) and returns a standard 500 response.
  • Empty Data Case: When a user has zero items, the generated file gracefully yields a file with headers but no data rows.

Result: The improvement in test coverage
The critical Excel generation feature is now covered with tests that verify internal correctness, ensuring that future refactoring will confidently preserve functionality without requiring manual QA.

Also cleans up app.request mutations properly and resolves package dependencies for testing locally.


PR created automatically by Jules for task 3871311524714203752 started by @deitaur

- Mocks authentication via mutating `app.request`.
- Mocks DB `pool.query` using Jest.
- Verifies output by parsing generated Excel workbook buffer.
- Adds happy path, error handling edge case and empty data case.
- Adds `supertest` and `jest` as dev dependencies.

Co-authored-by: deitaur <113350206+deitaur@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant