🧪 Add tests for GET /api/export-excel#6
Conversation
- Mocks authentication via mutating `app.request`. - Mocks DB `pool.query` using Jest. - Verifies output by parsing generated Excel workbook buffer. - Adds happy path, error handling edge case and empty data case. - Adds `supertest` and `jest` as dev dependencies. Co-authored-by: deitaur <113350206+deitaur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed
The
GET /api/export-excelendpoint lacked testing for its complex stream response containing an Excel file.📊 Coverage: What scenarios are now tested
500response.✨ Result: The improvement in test coverage
The critical Excel generation feature is now covered with tests that verify internal correctness, ensuring that future refactoring will confidently preserve functionality without requiring manual QA.
Also cleans up
app.requestmutations properly and resolves package dependencies for testing locally.PR created automatically by Jules for task 3871311524714203752 started by @deitaur