🧹 [code health improvement] Refactor complex type conditional logic in script.js#3
🧹 [code health improvement] Refactor complex type conditional logic in script.js#3deitaur wants to merge 1 commit into
Conversation
This change addresses a code health issue where there were over 30 instances of long if-else chains checking `effectiveParent.type === 'root'` or `lastStep.type === 'house'`, etc. By introducing a centralized `TYPE_CONFIG` object, this logic has been drastically simplified, making the code much easier to read and maintain. Changes: - Added `TYPE_CONFIG` to map each type (`root`, `house`, `room`, `cabinet`, `shelf`, `container`, `pocket`) to its properties (allowed child types, API endpoint, parent ID field, and view action). - Created a `refreshView(step)` helper to handle navigation and view updates autonomously. - Refactored `updateForm` to dynamically populate UI using `TYPE_CONFIG`. - Refactored `handleSubmitItemForm` to determine the proper request payload using `TYPE_CONFIG.apiMap`. - Refactored the restoration logic across breadcrumbs, item listing, form handling, and deletion to utilize `refreshView(step)`. Co-authored-by: deitaur <113350206+deitaur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Simplified complex
if-elsechains inpublic/script.jsrelated to the entitytype(root,house,room, etc.). Created a centralizedTYPE_CONFIGmapping and arefreshViewhelper.💡 Why: Over 30 instances of deeply nested conditional logic made the codebase hard to maintain and read. Consolidating these rules into a single configuration object improves maintainability, making it much easier to add new types in the future or alter behavior for existing ones.
✅ Verification: Verified that the core logic correctly maps to the previous one without regressions. Validated script syntax with
node -c public/script.js.✨ Result: Improved code health and maintainability of the frontend logic by significantly reducing duplication and cyclomatic complexity.
PR created automatically by Jules for task 4219499729031493131 started by @deitaur