test(e2e): add precheck for affinity and toleration e2e#2418
Open
LopatinDmitr wants to merge 1 commit into
Open
test(e2e): add precheck for affinity and toleration e2e#2418LopatinDmitr wants to merge 1 commit into
LopatinDmitr wants to merge 1 commit into
Conversation
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
a0bac9a to
db470ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a dedicated e2e precheck for
VirtualMachineAffinityAndToleration.The test now declares its infrastructure dependency explicitly instead of using
precheck.NoPrecheck.The new precheck validates that the cluster has enough ready KVM-enabled nodes for the placement and migration scenarios covered by the test.
Why do we need it, and what problem does it solve?
VirtualMachineAffinityAndTolerationdepends on cluster topology:Before this change, the test used
NoPrecheck, so these requirements were implicit and failures happened later during test execution.With the new precheck, an unsuitable cluster is rejected during the precheck phase with a clear error message.
What is the expected result?
FOCUS=VirtualMachineAffinityAndToleration.SynchronizedBeforeSuitewith a descriptive precheck error.Checklist
Changelog entries