feat: update protobuf.js v7.5.7#402
Open
braianj wants to merge 3 commits into
Open
Conversation
protobufjs 7.5.7's bundled descriptor.proto is not valid proto3 (uses string literals where enums expected, mixes tags/names in reserved, sets repeated message options as singular). It cannot be parsed by buf. Replace the build-time copy from node_modules with vendored upstream files (protocolbuffers/protobuf v21.12) so the runtime upgrade is independent of the .proto contracts.
Test this pull request
|
proto-compatibility-tool (last released 2022) iterates protobufjs internals in a way that's incompatible with protobufjs >=7.5: it crashes on string reservations and OOMs while walking the namespace tree. The runtime dependency stays on ^7.5.7 (consumers of @dcl/protocol get the secure version); the override only affects the dev-time tool. Also patch the tool's lone 'How to handle string reservations?' throw so it skips strings rather than aborting — keeps the tool's pre-upgrade coverage on numeric reservations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.