feat: scene-driven movement animations#392
Open
robtfm wants to merge 2 commits into
Open
Conversation
Adds `MovementAnimation` on `PBAvatarMovement` so the movement scene can drive avatar animation directly (src, loop, speed, idle, optional transition/seek). When unset the engine falls back to its velocity-based selection. Adds `AvatarAnimationState` on `PBAvatarMovementInfo` so any scene can observe the currently-playing scene-driven clip (src, loop, speed, idle, playback_time, duration, loop_count). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Test this pull request
|
This was referenced Apr 20, 2026
Scene-relative audio clip paths to play on the avatar audio bus when the scene wants a sound to ride the animation (e.g. footsteps at foot-plant playback times). Fire-and-forget: clips play once per frame they appear; no stop mechanism. Scene watches AvatarAnimationState.playback_time to decide when to set the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MovementAnimationonPBAvatarMovementso the movement scene can drive avatar animation directly (src,loop,speed,idle, optionaltransition_seconds, optionalplayback_time). When absent the engine falls back to its built-in velocity-based selection.AvatarAnimationStateonPBAvatarMovementInfoso any scene can observe the currently-playing scene-driven clip (src,loop,speed,idle,playback_time,duration,loop_count).playback_timefreezes while atriggerSceneEmoteis overriding the clip.Opened against
protocol-squadso we can build a remote artifact to linkjs-sdk-toolchainagainst, and in turn linkmovement-sceneso the downstream PRs are functional off this machine.🤖 Generated with Claude Code