Update SQL server relations to not require an alias#604
Open
Benjamin-Knight wants to merge 4 commits into
Open
Update SQL server relations to not require an alias#604Benjamin-Knight wants to merge 4 commits into
Benjamin-Knight wants to merge 4 commits into
Conversation
set dbt_sqlserver_disable_empty_relation_aliases default to True keep SQL Server relation _render_limited_alias() hook for no-alias behavior update empty-mode fixture SQL to use explicit user aliases so default no-alias behavior is valid preserve opt-in flag path/test for user validation
Collaborator
|
@Benjamin-Knight Please merge if ready, they reverted to true this for some reason for v1.10 microsoft/dbt-fabric@4aca77d |
Collaborator
Author
|
I'll double check this statement they have in the pull request for 1.10. Updated the require_alias attribute in FabricRelation to True, aligning with dbt-core 1.10.0 requirements. I do not remember seeing that requirement but will ensure that is the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595
Any project that uses the empty flag and expect the adapter to set aliases would find it no longer works.