Skip to content

Fix typos in code comments #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mokashang wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Fix typos in code comments #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ Contributors:
* Devadathan M B (devadathanmb)
* Charalampos Stratakis
* Laszlo Bimba (bimlas)
* MJSHANG (mokashang)

Creator:
--------
Expand Down
4 changes: 4 additions & 0 deletions changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Bug fixes:
* Hide timezone notice at startup when local and server timezones are the same.
* Let `sqlparse` accept arbitrarily-large queries.

Internal:
---------
* Fix typos in code comments.

Copy link
Copy Markdown
Member

@dbaty dbaty May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not pollute the changelog with this: it's not useful to users. Can you remove this, please?

Also, I am not sure your changes warrant an update of AUTHORS. Unless you absolutely want your name there, of course. ;)

4.4.0 (2025-12-24)
==================

Expand Down
4 changes: 2 additions & 2 deletions pgcli/pgexecute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
ViewDef = namedtuple("ViewDef", "nspname relname relkind viewdef reloptions checkoption")


# we added this funcion to strip beginning comments
# because sqlparse didn't handle tem well. It won't be needed if sqlparse
# we added this function to strip beginning comments
# because sqlparse didn't handle them well. It won't be needed if sqlparse
# does parsing of this situation better


Expand Down
2 changes: 1 addition & 1 deletion tests/test_pgexecute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def test_execute_commented_first_line_and_special(executor, pgspecial, tmpdir):
assert result[0].find("No help") >= 0

# TODO: we probably don't want to do this but sqlparse is not parsing things well
# we relly want it to find help but right now, sqlparse isn't dropping the /*comment*/
# we really want it to find help but right now, sqlparse isn't dropping the /*comment*/
# style comments after command

statement = r"""/*comment1*/
Expand Down
Loading