NOAA_GlobalForecastSystem_reorg_gcs_output_monthly#2017
Closed
balit-raibot wants to merge 3 commits into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the GCS output path in grib_statvar_processor.py to include year and month subdirectories. A review comment points out that this change must be reflected in the manifest.json glob patterns to ensure the ingestion pipeline continues to function correctly.
Contributor
Author
|
@gemini-code-assist review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GCS output path in grib_statvar_processor.py to organize files into year and month subdirectories based on the date string. The manifest.json file is updated accordingly to ensure the glob pattern matches the new directory structure. I have no feedback to provide as there were no review comments.
saanikaaa
approved these changes
May 19, 2026
Contributor
|
Pls add import name in PR title |
balit-raibot
changed the title
balit-raibot
deleted the
NOAA_GlobalForecastSystem_reorg_gcs_output_monthly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to reorganize the output path of NOAA processed files in GCS.
Earlier Path: gs://datcom-prod-imports/scripts/noaa_gfs/NOAA_GlobalForecastSystem/output/
Changed Path: gs://datcom-prod-imports/scripts/noaa_gfs/NOAA_GlobalForecastSystem/output/{YYYY}/{MM}/
The concern was raised by @hareesh-ms that the files will grow with time and thus should be organized month wise. Refer comment section in the document: https://docs.google.com/document/d/1jrazxQfcpB3u0YTzC8wBTG9a3KgB49KIpioCDb9OfVs/edit?resourcekey=0-kltavlIE_RN_BGurfvVrBQ&tab=t.0
Bug: https://buganizer.corp.google.com/issues/513413769