WHO Tuberculosis Rifampicin Resistant Data Import#2016
Open
pravnkumar-cloudsufi wants to merge 3 commits into
Open
WHO Tuberculosis Rifampicin Resistant Data Import#2016pravnkumar-cloudsufi wants to merge 3 commits into
pravnkumar-cloudsufi wants to merge 3 commits into
Conversation
Author
|
Hi @saanikaaa Please review the PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new data import for WHO Tuberculosis treatment outcomes related to rifampicin-resistant and MDR-TB. The implementation includes a Python script for data retrieval and merging, along with the required configuration and test files. Feedback focuses on correcting the manifest's script paths and filenames, adding timeouts to network requests, handling potential unmapped countries during data merging to avoid invalid DCIDs, and resolving inconsistencies between the metadata configuration and the test output format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kindly find the PR Checklist: https://docs.google.com/spreadsheets/d/1DP2SvoEwoU6VXvKucE9xiABKRVDzEx-D/edit?resourcekey=0-AaGcMXwYDzrz9obQi2_JbQ&gid=262592105#gid=262592105