Cleanup: neutralize surface table, fix skill wording, drop stale PI.md#11
Merged
Conversation
- Surface table: 'computer use' -> 'direct UI control', 'browser automation MCP server (claude-in-chrome or Playwright)' -> 'a browser automation driver'. Both bindings map the new terms (Claude: computer use / browser MCP; Pi: unavailable / Playwright via Bash). Removes the last Claude-specific tokens from the skills. Closes the surface-neutralization part of #5. - Skill preambles now say 'This skill' not 'This command'. - (Also deleted the stale untracked PI.md port-analysis doc, superseded by docs/harness-bindings/.)
There was a problem hiding this comment.
Pull request overview
This PR performs post-merge documentation cleanups to keep the forge skills harness-neutral and to align the harness binding docs with the new neutral “surface” terminology.
Changes:
- Updates the three skill preambles to say “This skill is written…” (vs “This command…”).
- Neutralizes the building skill’s evaluation-surface wording (e.g., “direct UI control”, “a browser automation driver”).
- Updates Pi + Claude Code harness binding docs to bind the new neutral surface terms.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/planning/SKILL.md | Updates harness-binding preamble wording (“skill” vs “command”). |
| skills/interview/SKILL.md | Updates harness-binding preamble wording (“skill” vs “command”). |
| skills/building/SKILL.md | Replaces Claude-specific surface/tool terms with neutral surface terminology in the building skill. |
| docs/harness-bindings/pi.md | Adds bindings for the new neutral surface terms and updates the evaluation-surfaces section. |
| docs/harness-bindings/claude-code.md | Adds bindings for the new neutral surface terms for Claude Code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
110
to
114
| 3. **Surface dependencies.** `web` is the only surface with an external | ||
| dependency: a browser automation MCP server (claude-in-chrome or | ||
| Playwright). Verify one is connected. If it is not, stop and offer three | ||
| choices: install one, fall back to `native` and drive the browser with | ||
| computer use, or abort. Never continue into Phase 1 with no way to run | ||
| dependency: a browser automation driver. Verify one is available. If it is | ||
| not, stop and offer three choices: install one, fall back to `native` (only | ||
| if your harness provides direct UI control), or abort. Never continue into Phase 1 with no way to run | ||
| Phase 6. |
| | exploratory | a read-only subagent (the `subagent` tool from `pi-subagents`, forked context) | | ||
| | a working scratch location | a `harness/` directory inside the worktree, git-excluded (per the building skill's `.git/info/exclude` step) | | ||
| | a browser automation driver | Playwright, driven via Bash | | ||
| | direct UI control | unavailable; Pi has no computer-use surface, so the native surface is skipped | |
| driver`, `direct UI control`) bound in the table above. On Pi they resolve as | ||
| follows: | ||
|
|
||
| - `native` (computer-use) surface: **unavailable**. Skip any step whose only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three post-merge cleanups after the skills conversion landed on
main.Neutralize the evaluation-surface table (the last Claude-specific coupling in the skills).
skills/building/SKILL.mdno longer namescomputer useorclaude-in-chrome:computer use(native surface) ->direct UI controla browser automation MCP server (claude-in-chrome or Playwright)->a browser automation driverBoth bindings map the new neutral terms:
a browser automation driver-> a browser MCP (claude-in-chrome or Playwright);direct UI control-> computer use.a browser automation driver-> Playwright via Bash;direct UI control-> unavailable (native surface skipped).pi.md's "not yet neutralized" surface section is updated to reflect that these are now bound. This closes the surface-neutralization part of Add a Pi/GLM-5.2 binding so the same commands run on Pi #5.Skill self-wording: the three preambles now say "This skill is written..." instead of "This command...".
Deleted the stale
PI.mdport-analysis doc (it was untracked cruft referencing the old commands, the 363-line building file, and the removed/code-review; superseded bydocs/harness-bindings/).Verification
skills/(claude-in-chrome,computer use,browser MCP,This command).