Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ Please send pull requests for bug fixes, code optimization, and ideas for improv

Code released under [the MIT license](LICENSE).

Copyright 2013-2017 BitPay, Inc. Bitcore is a trademark maintained by BitPay, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.
Comment on lines 152 to +154
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Copyright lines lose hard line breaks and render as one run-on paragraph

Verified against the diff: the removed lines ended with two trailing spaces (GFM hard-break markers), and the replacement lines do not. In GitHub-Flavored Markdown, consecutive non-blank lines inside the same paragraph are joined with a single space on render unless each non-final line ends with two trailing spaces, a backslash, or <br>. As-is, the three copyright notices will display as one wrapped paragraph (Copyright 2017-2020 Dash Core Group, Inc. Copyright 2016-2017 The Dash Foundation, Inc. Copyright 2013-2017 BitPay, Inc.) instead of three separate lines as before. Restoring the two trailing spaces on the first two lines preserves the prior rendering.

Suggested change
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.

source: ['claude']