[AI] Object mask: better boundaries, more consistent single-click results#20988
Open
andriiryzhkov wants to merge 6 commits into
Open
[AI] Object mask: better boundaries, more consistent single-click results#20988andriiryzhkov wants to merge 6 commits into
andriiryzhkov wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I collected feedback in the pixls.us testing thread and the two issues people raised most consistently were that the mask boundary didn't track the image well, and that clicking felt hit-and-miss – repeated clicks didn't reliably improve the result. This PR addresses both.
What I changed
What users will notice
refine_passesdefault from 1 → 2 and lowered the max from 5 → 3.render_sizedefault 1024 → 1536 (the CRF needs more spatial detail than the encoder's internal 1024). I tested this at length; quality/speed feels right at 1536.smoothingdefault changed from 1.0 → 0.0 – only affects new users' first vectorization output, but worth flagging in release notes.Note for testers and existing users
Several default values changed in this PR. Existing
darktablercentries override defaults, so users who tested earlier nightlies won't pick up the new defaults automatically. To get the new behavior, delete all object-mask conf keys before launching darktable.One-liner to strip the keys (Linux/macOS):
This removes all
plugins/darkroom/masks/object/*lines and keeps a.baknext to the original. On next launch, darktable repopulates them with the new defaults.