Conversation
Contributor
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 1a65321 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the unattended upgrades script to better support both Debian and Ubuntu by introducing distribution-specific configuration blocks for unattended upgrades. The script now detects the Linux distribution and applies the correct configuration format, improving compatibility and maintainability.
Distribution-specific unattended upgrades configuration:
Added separate unattended-upgrades configuration blocks for Debian (
debian_unattended_upgrades_origins) and Ubuntu (ubuntu_unattended_upgrades_origins), using the correctOrigins-Patternsyntax for each distro.Introduced the
set_unattended_upgrades_config_for_distrofunction, which detects the distro via/etc/os-releaseand sets the appropriate configuration. If the distro is unsupported or unknown, the script logs a warning and skips configuration changes.Script logic and maintainability improvements:
Updated the main script logic to call
set_unattended_upgrades_config_for_distroand only write the unattended-upgrades config file if the function succeeds, preventing accidental misconfiguration on unsupported systems.Removed the old, hardcoded
unattended_upgrades_configblock in favor of the new, distro-specific approach, and separated common options intounattended_upgrades_optionsfor reuse.