Improve pull request conversations#47
Merged
Merged
Conversation
danielss-dev
marked this pull request as ready for review
July 13, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing conversation view was visually sparse and offered only a plain textarea. Review discussions now have clearer author/context separation and a composer that supports the Markdown workflows people expect without leaving Strand.
User impact
Comments are easier to scan and compose. Provider avatars load lazily with no referrer; arbitrary images in PR content remain inert until the user explicitly reveals them. Direct local binary attachment upload is intentionally not presented because the supported GitHub and Azure CLI paths do not share a stable attachment API.
Validation
cargo check -p strand-core -p strand-tauricargo test -p strand-tauri(25 passed)pnpm --filter ./ui exec vitest run(212 passed)pnpm --filter ./ui exec tsc --noEmit