Add support for updated error text upon Zarr name conflicts#1848
Merged
Conversation
Newer versions of the DANDI API will return a different error text when a duplicate Zarr (same name, same dandiset) is created. This is due to more rigorous early checking by Django Rest Framework and cannot easily be changed. This ensures that any version of the API is supported, as the old error text is still matched too.
Contributor
Author
|
This is necessary to address integration test failures in dandi/dandi-archive#2589. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 76.26% 76.25% -0.02%
==========================================
Files 87 87
Lines 12486 12486
==========================================
- Hits 9523 9521 -2
- Misses 2963 2965 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
approved these changes
Apr 30, 2026
Member
|
will release with some subsequent PR like to debounce releases a little ;) |
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of the DANDI API will return a different error text when a duplicate Zarr (same name, same dandiset) is created. This is due to more rigorous early checking by Django Rest Framework and cannot easily be changed.
This ensures that any version of the API is supported, as the old error text is still matched too.