Fix timezone-aware datetime conversion#128
Merged
Merged
Conversation
Previously, dt.replace(tzinfo=timezone.utc) silently discarded any existing timezone info, treating e.g. a UTC-5 datetime as if it were UTC. Now tz-aware datetimes use astimezone() for proper conversion, while naive datetimes continue to be assumed UTC for backward compat. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9721b45. Configure here.
joeybaer
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
_datetime_to_timestamp()useddt.replace(tzinfo=timezone.utc)which silently discards existing timezone info instead of converting — a datetime at UTC-5 would be treated as UTC, producing the wrong timestampdt.astimezone(timezone.utc)for tz-aware datetimes, preservingdt.replace()only for naive datetimes (backward compatible)Test plan
🤖 Generated with Claude Code
Note
Medium Risk
Changes how timestamps are generated for tz-aware
datetimevalues, which can alter event/customer data sent to the API for non-UTC inputs. Scope is small and covered by added unit tests, but impacts payload correctness.Overview
Fixes datetime sanitization so timezone-aware
datetimevalues are converted to UTC before timestamping (usingastimezone(timezone.utc)) instead of silently overriding their timezone viareplace().Keeps prior behavior for naive datetimes (assumed UTC) and adds tests for naive, UTC-aware, and non-UTC-aware datetime inputs to prevent regressions.
Reviewed by Cursor Bugbot for commit c7fd1cc. Bugbot is set up for automated code reviews on this repo. Configure here.