Fix nested sanitization of datetime and NaN values#127
Merged
Conversation
datetime and NaN values nested inside dicts or lists were passed through unsanitized because _sanitize_value() only handled flat values. Add recursion for dict (via _sanitize()) and list types.
joeybaer
approved these changes
May 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_sanitize_value()only handled top-level dict values —datetimeandNaNinside nested dicts or lists passed through unsanitized, causingTypeErrorduring JSON serialization or silent data corruptiondictandlisttypes in_sanitize_value()Test plan
datetimeconverts to timestampdatetimevalues converts correctlyNaNconverts toNone🤖 Generated with Claude Code
Note
Low Risk
Low risk: limited to request payload sanitization, extending existing datetime/NaN handling to nested dicts/lists and backed by new unit tests.
Overview
Fixes payload sanitization so
datetimeandNaNvalues are converted even when nested inside dicts or lists before JSON requests are sent.Adds recursive handling in
ClientBase._sanitize_value()and extends the test suite with cases for nested dicts, lists, and deeply nested structures (plus minor test formatting cleanups).Reviewed by Cursor Bugbot for commit 9d04324. Bugbot is set up for automated code reviews on this repo. Configure here.