Add English locale and i18n support for popup UI#1
Open
adc103 wants to merge 1 commit into
Open
Conversation
The popup UI was hardcoded in Spanish (popup.html, popup.js, and the manifest description), with no way to view it in English. - Add chrome.i18n support via _locales/en and _locales/es - Replace hardcoded strings in popup.html with data-i18n attributes - Replace hardcoded strings in popup.js with chrome.i18n.getMessage() calls - Add default_locale to manifest.json and switch name/description to __MSG_*__ placeholders - Bump version to 1.3.0 and update changelog Popup language now follows the browser's UI language, falling back to English if the locale isn't available. No functional changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds English support to the popup UI via chrome.i18n, alongside the existing Spanish. Popup language now follows the browser's UI locale (standard Chrome extension i18n behavior) rather than a manual switcher — happy to add an in-popup toggle if preferred. Bumped to 1.3.0 since this adds a feature rather than fixing a bug.