Skip to content

Solved console format issues#175

Merged
teodutu merged 1 commit into
cs-pub-ro:mainfrom
razvan206:razvan206/console_format_issue
May 16, 2026
Merged

Solved console format issues#175
teodutu merged 1 commit into
cs-pub-ro:mainfrom
razvan206:razvan206/console_format_issue

Conversation

@razvan206

Copy link
Copy Markdown

Solved console format issues for all labs in hardware-software-interface/labs.

@teodutu teodutu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good, but the checkpatch CI action is failing [1]. Add a commit description explaining your changes and a signed-off-line. You can do so with:

$ git commit -s --amend  # This will add the signed-off-by line with -s and then open your default editor where you can modify the commit message

$ git log  # Inspect the new commit message

$ git push -f   # Update the remote repo (and PR) with the changed commit. You need -f because you've overwritten an existing commit.

[1] https://github.com/cs-pub-ro/hardware-software-interface/actions/runs/24927785750/job/73009789008?pr=175

@teodutu teodutu linked an issue Apr 28, 2026 that may be closed by this pull request
@razvan206 razvan206 force-pushed the razvan206/console_format_issue branch from 89fe726 to 6a8eb85 Compare May 9, 2026 08:56
@razvan206 razvan206 requested a review from teodutu May 15, 2026 13:52
Standardize the formatting for console output and reading material links
across multiple lab tasks to ensure consistency and fix CI checkpatch
failures.

Signed-off-by: Razvan <razvyvoica@gmail.com>
@razvan206 razvan206 force-pushed the razvan206/console_format_issue branch from 6a8eb85 to c05bfcd Compare May 16, 2026 08:43

@teodutu teodutu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@teodutu teodutu merged commit 644aaf4 into cs-pub-ro:main May 16, 2026
3 checks passed
@teodutu teodutu added the student-contrib Fix or improvement made by a student label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

student-contrib Fix or improvement made by a student

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chapters: Reformat console code blocks to include CLI prompt

2 participants