Skip to content

discard junk domain#238

Merged
buixor merged 1 commit into
masterfrom
discard_invalid_domains
Jun 23, 2026
Merged

discard junk domain#238
buixor merged 1 commit into
masterfrom
discard_invalid_domains

Conversation

@buixor

@buixor buixor commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 23, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow that syncs/merges disposable email domain sources so that the generated list filters out malformed/junk entries before writing the merged output file.

Changes:

  • Replaces comment/blank-line stripping on file-based inputs with a single “well‑formed domain name” validation filter across all sources.
  • Adds workflow documentation explaining why upstream feeds can contain junk and how the validation works.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/temp-email-domains.yml

@sabban sabban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buixor buixor merged commit c32112a into master Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants