update disposable domain list: add our own, add castle domains too#234
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the disposable email domain list generation to merge multiple upstream sources (DeviceAndBrowserInfo + Castle) along with a repo-maintained CrowdSec list, improving coverage while keeping a single canonical output file.
Changes:
- Expand attribution in
disposable_email_domains.datato reflect multiple sources. - Add
appsec/crowdsec_disposable_email_domains.dataas the repo-maintained input list for CrowdSec-sourced domains. - Update the
temp-email-domains.ymlworkflow to download/validate the Castle list and merge all sources into the generated output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
appsec/disposable_email_domains.data |
Updates header attribution to list multiple sources feeding the merged domain list. |
appsec/crowdsec_disposable_email_domains.data |
Adds a CrowdSec-maintained input list intended to be merged into the canonical output. |
.github/workflows/temp-email-domains.yml |
Extends the sync workflow to fetch Castle and merge it with the remote JSON + CrowdSec source file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.