Use relative rather than absolute symlink in t/analyse/manifest.t#51
Open
pghmcfc wants to merge 1 commit into
Open
Use relative rather than absolute symlink in t/analyse/manifest.t#51pghmcfc wants to merge 1 commit into
pghmcfc wants to merge 1 commit into
Conversation
Archive::Tar since version 3.08 will refuse to extract absolute symlinks unless $Archive::Tar::INSECURE_EXTRACT_MODE is set, leading to this test suite failure: Symlink 'Module-CPANTS-Analyse-Test-0.01/MANIFEST.lnk' has absolute target. Not extracting under SECURE EXTRACT MODE at /usr/share/perl5/vendor_perl/Archive/Any/Lite.pm line 130. t/analyse/manifest.t ..... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/14 subtests This problem can be avoided by using relative symlinks: MANIFEST.lnk -> MANIFEST rather than absolute symlinks: MANIFEST.lnk -> /path/to/tmpdir/MANIFEST in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archive::Tarsince version 3.08 will refuse to extract absolute symlinks unless$Archive::Tar::INSECURE_EXTRACT_MODEis set, leading to this test suite failure:This problem can be avoided by using relative symlinks:
MANIFEST.lnk -> MANIFEST
rather than absolute symlinks:
MANIFEST.lnk -> /path/to/tmpdir/MANIFEST
in the test.