feat(codegen): add cleanStaleTargets option to generateMulti#1247
Merged
Conversation
Add removeStaleTargetDirs() utility and cleanStaleTargets option to generateMulti(). When enabled, scans the output root and removes subdirectories that don't match any current target name — eliminating the need for pregenerate scripts with hardcoded directory lists. Exported as a standalone function for direct use by generate scripts.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
All three SDK generate scripts (constructive-sdk, constructive-cli, constructive-react) now pass cleanStaleTargets: true to generateMulti. Remove the pregenerate npm scripts with hardcoded target directories — stale directory cleanup is now handled automatically by the codegen.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates hardcoded target directory lists across the SDK generation pipeline. Two changes:
graphql-codegen: AddscleanStaleTargets?: booleantoGenerateMultiOptionsand exportsremoveStaleTargetDirs(). When enabled,generateMulti()auto-removes output subdirectories that don't match any current target name before generating — replacing manualrimrafcleanup.All 3 SDK generate scripts (
constructive-sdk,constructive-cli,constructive-react): PasscleanStaleTargets: truetogenerateMulti(). Removepregeneratescripts that hardcodedrimraf src/admin src/auth src/objects src/public src/index.ts— stale cleanup is now automatic and schema-driven.Part of a 3-PR series:
API_NAMESfromAPI_SCHEMA_MAPLink to Devin session: https://app.devin.ai/sessions/169e0931b82147e3b52ad3d8d704c17d
Requested by: @pyramation