Skip to content

Remove github enterprise workaround#150

Open
taylorsilva wants to merge 2 commits intomasterfrom
issue-149
Open

Remove github enterprise workaround#150
taylorsilva wants to merge 2 commits intomasterfrom
issue-149

Conversation

@taylorsilva
Copy link
Copy Markdown
Member

Resolves #149

See #149 (comment)

all github enterprise versions now have a DatabaseId returned. it's been
this way since v3.2 of github enterprise. Current version of enterprise
is v3.20

Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
@taylorsilva taylorsilva requested a review from a team as a code owner April 15, 2026 20:13
@taylorsilva
Copy link
Copy Markdown
Member Author

@MiliDurasovic I don't have access to github enterprise. If you can verify this resolves the issue then I'll merge it. TY!

@MiliDurasovic
Copy link
Copy Markdown

@taylorsilva Thanks! I will test it out asap and give you feedback.

@MiliDurasovic
Copy link
Copy Markdown

@taylorsilva
Creation of the release was now succesful. Thanks!

I got another error, but I think it is unrelated. The asset is around 180MB and the upload fails after migrating to GHEC.
Strangely it times out afterwards when trying to get the list of assets:

selected worker: 01b1633a-455d-4c83-866d-7e1b6a195b50
creating release v3.0.3-rc-202604160748
uploading /tmp/build/put/csb-brokerpak-output/aws-services-3.0.3.brokerpak
error running command: Get "https://api.REDACTED.ghe.com/repos/OWNER/REPO/releases/4891372/assets?per_page=100": read tcp 10.80.0.50:49248->20.240.194.241:443: read: connection timed out

But running it via curl from within the worker works just fine. Also uploading the asset via curl works.
So it might be a seperate MTU issue related to garden?

As mentioned, since the tests are passing and the actual release creation works, I think you can merge the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Enterprise Cloud - New node_id format results in "error running command: illegal base64 data at input byte 2" during release creation

2 participants