Skip to content

Prevent ConfirmDialog di remount on every open/close#1166

Open
gciotola wants to merge 4 commits into
mainfrom
fix/1165-confirm-dialog-scroll
Open

Prevent ConfirmDialog di remount on every open/close#1166
gciotola wants to merge 4 commits into
mainfrom
fix/1165-confirm-dialog-scroll

Conversation

@gciotola

Copy link
Copy Markdown
Contributor

Closes #1165

@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit 629760b
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-app-elements/deploys/6a3bcd5ef4138d0008208c2c
😎 Deploy Preview https://deploy-preview-1166--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gciotola gciotola changed the title fix: prevent ConfirmDialog di remount on every open/close Prevent ConfirmDialog di remount on every open/close Jun 24, 2026
@gciotola gciotola self-assigned this Jun 24, 2026
@gciotola gciotola added the bug Something isn't working label Jun 24, 2026
malessani
malessani previously approved these changes Jun 24, 2026
pfferrari
pfferrari previously approved these changes Jun 24, 2026
@gciotola gciotola dismissed stale reviews from pfferrari and malessani via f868e02 June 24, 2026 10:59
@pkg-pr-new

pkg-pr-new Bot commented Jun 24, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/commercelayer/app-elements/@commercelayer/app-elements@1166

commit: 629760b

@gciotola gciotola force-pushed the fix/1165-confirm-dialog-scroll branch from f868e02 to b8120b2 Compare June 24, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page body scroll stays locked after closing ConfirmDialog

3 participants