chore: add new managed service providers #462
Draft
utkuerol wants to merge 2 commits into
Draft
Conversation
Signed-off-by: utkuerol <utku.erol@icloud.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PoC managed service providers (rabbitmq, valkey, opensearch) to the installer’s default codesphere.managedServices list and extends the config schema / resource-profile handling to include additional managed-service backend components.
Changes:
- Extend default
Codesphere.ManagedServicesto includeopensearch,rabbitmq, andvalkey(allv0). - Extend
ManagedServiceBackendsConfigschema withk8sBackendandrabbitMqOperatorentries (plus new config types). - Update the
noRequestsresource profile to initialize/apply overrides for the newk8sBackendbackend and to initialize the RabbitMQ operator backend config; update tests accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/installer/resource_profiles.go | Initializes new managed-service backend configs under the noRequests resource profile and applies zero-request resource overrides for k8sBackend. |
| internal/installer/resource_profiles_test.go | Adds assertions for the new managed-service backend fields under the noRequests profile. |
| internal/installer/files/config_yaml.go | Extends the YAML config schema for managedServiceBackends to include k8sBackend and rabbitMqOperator. |
| internal/installer/config_manager_profile.go | Adds opensearch, rabbitmq, and valkey to the default managed services list. |
| internal/installer/config_manager_profile_test.go | Updates managed-services expectations to include the new providers and new total count. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| S3 *S3ManagedServiceConfig `yaml:"s3,omitempty"` | ||
| Postgres *PgManagedServiceConfig `yaml:"postgres,omitempty"` | ||
| S3 *S3ManagedServiceConfig `yaml:"s3,omitempty"` | ||
| RabbitMqOperator *RabbitMqOperatorConfig `yaml:"rabbitMqOperator,omitempty"` |
Comment on lines
178
to
188
| if g.Config.Codesphere.ManagedServices == nil { | ||
| g.Config.Codesphere.ManagedServices = []files.ManagedServiceConfig{ | ||
| {Name: "postgres", Version: "v1"}, | ||
| {Name: "babelfish", Version: "v1"}, | ||
| {Name: "s3", Version: "v1"}, | ||
| {Name: "virtual-k8s", Version: "v1"}, | ||
| {Name: "ferretdb", Version: "v0"}, | ||
| {Name: "opensearch", Version: "v0"}, | ||
| {Name: "rabbitmq", Version: "v0"}, | ||
| {Name: "valkey", Version: "v0"}, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have 3 new providers (rabbitmq, valkey, opensearch) in PoC state which we would like to be able to early QA towards a preview state. This PR adds the new providers to
config.managedServicesand the new required components toconfig.managedServiceBackends.