Skip to content

Revert "Pure Codename One rich text and code editors (remove BrowserComponent)"#5385

Merged
shai-almog merged 1 commit into
masterfrom
revert-5378-pure-cn1-editors
Jul 15, 2026
Merged

Revert "Pure Codename One rich text and code editors (remove BrowserComponent)"#5385
shai-almog merged 1 commit into
masterfrom
revert-5378-pure-cn1-editors

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

Reverts #5378

@shai-almog shai-almog merged commit c2d12f8 into master Jul 15, 2026
47 of 48 checks passed
@shai-almog shai-almog deleted the revert-5378-pure-cn1-editors branch July 15, 2026 14:18
@github-actions

Copy link
Copy Markdown
Contributor

Blog prose gate

✅ No net-new prose findings introduced by this PR.

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 12 screenshots: 12 matched.
✅ JavaSE simulator integration screenshots matched stored baselines.

@github-actions

Copy link
Copy Markdown
Contributor

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

  • AsciiDoc linter: No issues found (report)
  • Vale: No alerts found (report)
  • Paragraph capitalization: No paragraph capitalization issues (report)
  • LanguageTool: No grammar matches (report)
  • Image references: No unused images detected (report)

@github-actions

Copy link
Copy Markdown
Contributor

✅ ByteCodeTranslator Quality Report

Test & Coverage

  • Tests: 395 total, 0 failed, 14 skipped

Benchmark Results

  • Execution Time: 19573 ms

  • Hotspots (Top 20 sampled methods):

    • 18.67% java.util.ArrayList.indexOf (321 samples)
    • 10.06% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (173 samples)
    • 3.32% com.codename1.tools.translator.ByteCodeClass.hasDeclaredMethod (57 samples)
    • 3.03% com.codename1.tools.translator.Parser.cn1EnsureSubclassIndex (52 samples)
    • 2.91% java.lang.StringBuilder.append (50 samples)
    • 2.68% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (46 samples)
    • 2.15% com.codename1.tools.translator.BytecodeMethod.equals (37 samples)
    • 2.15% com.codename1.tools.translator.Parser.classIndex (37 samples)
    • 2.09% org.objectweb.asm.tree.analysis.Analyzer.findSubroutine (36 samples)
    • 1.92% java.util.HashMap.hash (33 samples)
    • 1.86% org.objectweb.asm.ClassReader.readCode (32 samples)
    • 1.69% java.lang.System.identityHashCode (29 samples)
    • 1.63% java.lang.String.equals (28 samples)
    • 1.63% com.codename1.tools.translator.BytecodeMethod.optimize (28 samples)
    • 1.57% java.lang.Object.hashCode (27 samples)
    • 1.57% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (27 samples)
    • 1.45% org.objectweb.asm.tree.analysis.Analyzer.analyze (25 samples)
    • 1.40% com.codename1.tools.translator.bytecodes.Invoke.resolveDirectTarget (24 samples)
    • 1.22% com.codename1.tools.translator.bytecodes.Invoke.findMethodUp (21 samples)
    • 0.99% com.codename1.tools.translator.ByteCodeClass.markDependent (17 samples)
  • ⚠️ Coverage report not generated.

Static Analysis

  • ✅ SpotBugs: no findings (report was not generated by the build).
  • ⚠️ PMD report not generated.
  • ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 168 screenshots: 168 matched.
✅ JavaScript-port screenshot tests passed.

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 141 screenshots: 141 matched.
Native Windows port (x64 / Intel-AMD): full hellocodenameone screenshot suite rendered offscreen with Direct2D/DirectWrite, plus the real benchmarks (base64 native/CN1/SIMD, image createMask/applyMask/modifyAlpha/PNG/JPEG, SSE2 SIMD kernels). Compared against the in-repo baseline in scripts/windows/screenshots.

Benchmark Results

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 118ms / native 7ms = 16.8x speedup
SIMD float-mul (64K x300) java 88ms / native 5ms = 17.6x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 native bridge unavailable (CN1 + SIMD + image benchmarks only)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode 301.000 ms
Base64 CN1 decode 150.000 ms
Base64 SIMD encode 151.000 ms
Base64 encode ratio (SIMD/CN1) 0.502x (49.8% faster)
Base64 SIMD decode 127.000 ms
Base64 decode ratio (SIMD/CN1) 0.847x (15.3% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 29.000 ms
Image createMask (SIMD on) 35.000 ms
Image createMask ratio (SIMD on/off) 1.207x (20.7% slower)
Image applyMask (SIMD off) 91.000 ms
Image applyMask (SIMD on) 72.000 ms
Image applyMask ratio (SIMD on/off) 0.791x (20.9% faster)
Image modifyAlpha (SIMD off) 67.000 ms
Image modifyAlpha (SIMD on) 71.000 ms
Image modifyAlpha ratio (SIMD on/off) 1.060x (6.0% slower)
Image modifyAlpha removeColor (SIMD off) 88.000 ms
Image modifyAlpha removeColor (SIMD on) 76.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.864x (13.6% faster)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 141 screenshots: 141 matched.
Native Windows port (arm64 / Apple Silicon - Arm): full hellocodenameone screenshot suite rendered offscreen with Direct2D/DirectWrite, plus the real benchmarks (base64 native/CN1/SIMD, image createMask/applyMask/modifyAlpha/PNG/JPEG, NEON SIMD kernels). Compared against the in-repo baseline in scripts/windows/screenshots.

Benchmark Results

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 54ms / native 3ms = 18.0x speedup
SIMD float-mul (64K x300) java 56ms / native 2ms = 28.0x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 native bridge unavailable (CN1 + SIMD + image benchmarks only)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode 245.000 ms
Base64 CN1 decode 127.000 ms
Base64 SIMD encode 65.000 ms
Base64 encode ratio (SIMD/CN1) 0.265x (73.5% faster)
Base64 SIMD decode 58.000 ms
Base64 decode ratio (SIMD/CN1) 0.457x (54.3% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 11.000 ms
Image createMask (SIMD on) 8.000 ms
Image createMask ratio (SIMD on/off) 0.727x (27.3% faster)
Image applyMask (SIMD off) 24.000 ms
Image applyMask (SIMD on) 18.000 ms
Image applyMask ratio (SIMD on/off) 0.750x (25.0% faster)
Image modifyAlpha (SIMD off) 15.000 ms
Image modifyAlpha (SIMD on) 12.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.800x (20.0% faster)
Image modifyAlpha removeColor (SIMD off) 19.000 ms
Image modifyAlpha removeColor (SIMD on) 13.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.684x (31.6% faster)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 141 screenshots: 141 matched.
Native Windows port, REAL shipping pipeline: the hellocodenameone screenshot suite rendered by a binary CROSS-COMPILED on Linux (clang-cl + xwin, WebView2 linked) and RUN on a Windows x64 runner. Compared against the in-repo baseline in scripts/windows/screenshots.

Benchmark Results

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 64ms / native 5ms = 12.8x speedup
SIMD float-mul (64K x300) java 64ms / native 4ms = 16.0x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 native bridge unavailable (CN1 + SIMD + image benchmarks only)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode 202.000 ms
Base64 CN1 decode 122.000 ms
Base64 SIMD encode 99.000 ms
Base64 encode ratio (SIMD/CN1) 0.490x (51.0% faster)
Base64 SIMD decode 89.000 ms
Base64 decode ratio (SIMD/CN1) 0.730x (27.0% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 28.000 ms
Image createMask (SIMD on) 24.000 ms
Image createMask ratio (SIMD on/off) 0.857x (14.3% faster)
Image applyMask (SIMD off) 63.000 ms
Image applyMask (SIMD on) 63.000 ms
Image applyMask ratio (SIMD on/off) 1.000x (0.0% slower)
Image modifyAlpha (SIMD off) 60.000 ms
Image modifyAlpha (SIMD on) 63.000 ms
Image modifyAlpha ratio (SIMD on/off) 1.050x (5.0% slower)
Image modifyAlpha removeColor (SIMD off) 63.000 ms
Image modifyAlpha removeColor (SIMD on) 63.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 1.000x (0.0% slower)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 145 screenshots: 145 matched.

Native Android coverage

  • 📊 Line coverage: 11.19% (11686/104408 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 9.96% (57613/578327), branch 5.10% (2696/52868), complexity 4.86% (2692/55433), method 7.30% (2083/28530), class 11.39% (461/4049)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 11.19% (11686/104408 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 9.96% (57613/578327), branch 5.10% (2696/52868), complexity 4.86% (2692/55433), method 7.30% (2083/28530), class 11.39% (461/4049)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
SIMD kernel backend scalar fallback (no native SIMD)
SIMD int-add (64K x300) java 183ms / native 120ms = 1.5x speedup
SIMD float-mul (64K x300) java 119ms / native 106ms = 1.1x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode 291.000 ms
Base64 CN1 decode 623.000 ms
Base64 native encode 1236.000 ms
Base64 encode ratio (CN1/native) 0.235x (76.5% faster)
Base64 native decode 1144.000 ms
Base64 decode ratio (CN1/native) 0.545x (45.5% faster)
Image encode benchmark status skipped (SIMD unsupported)

@github-actions

Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ByteCodeTranslator: 0 findings (no issues)
    • android: 0 findings (no issues)
    • codenameone-maven-plugin: 0 findings (no issues)
    • core-unittests: 0 findings (no issues)
    • ios: 0 findings (no issues)
  • PMD: 0 findings (no issues) [Report archive]
  • Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare Preview

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 143 screenshots: 143 matched.
✅ Native Mac screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 234 seconds

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 73ms / native 3ms = 24.3x speedup
SIMD float-mul (64K x300) java 101ms / native 4ms = 25.2x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path active (NEON-accelerated)
Base64 CN1 encode 351.000 ms
Base64 CN1 decode 176.000 ms
Base64 native encode 1288.000 ms
Base64 encode ratio (CN1/native) 0.273x (72.7% faster)
Base64 native decode 52128.000 ms
Base64 decode ratio (CN1/native) 0.003x (99.7% faster)
Base64 SIMD encode 72.000 ms
Base64 encode ratio (SIMD/CN1) 0.205x (79.5% faster)
Base64 SIMD decode 75.000 ms
Base64 decode ratio (SIMD/CN1) 0.426x (57.4% faster)
Base64 encode ratio (SIMD/native) 0.056x (94.4% faster)
Base64 decode ratio (SIMD/native) 0.001x (99.9% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 255.000 ms
Image createMask (SIMD on) 239.000 ms
Image createMask ratio (SIMD on/off) 0.937x (6.3% faster)
Image applyMask (SIMD off) 712.000 ms
Image applyMask (SIMD on) 1042.000 ms
Image applyMask ratio (SIMD on/off) 1.463x (46.3% slower)
Image modifyAlpha (SIMD off) 638.000 ms
Image modifyAlpha (SIMD on) 371.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.582x (41.8% faster)
Image modifyAlpha removeColor (SIMD off) 471.000 ms
Image modifyAlpha removeColor (SIMD on) 418.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.887x (11.3% faster)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 139 screenshots: 139 matched.
✅ Native Apple TV (tvOS, Metal) screenshot tests passed.

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 138 screenshots: 138 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 525 seconds

Build and Run Timing

Metric Duration
Simulator Boot 91000 ms
Simulator Boot (Run) 2000 ms
App Install 44000 ms
App Launch 2000 ms
Test Execution 648000 ms

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 103ms / native 6ms = 17.1x speedup
SIMD float-mul (64K x300) java 100ms / native 4ms = 25.0x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path active (NEON-accelerated)
Base64 CN1 encode 225.000 ms
Base64 CN1 decode 155.000 ms
Base64 native encode 1496.000 ms
Base64 encode ratio (CN1/native) 0.150x (85.0% faster)
Base64 native decode 575.000 ms
Base64 decode ratio (CN1/native) 0.270x (73.0% faster)
Base64 SIMD encode 69.000 ms
Base64 encode ratio (SIMD/CN1) 0.307x (69.3% faster)
Base64 SIMD decode 57.000 ms
Base64 decode ratio (SIMD/CN1) 0.368x (63.2% faster)
Base64 encode ratio (SIMD/native) 0.046x (95.4% faster)
Base64 decode ratio (SIMD/native) 0.099x (90.1% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 8.000 ms
Image createMask (SIMD on) 4.000 ms
Image createMask ratio (SIMD on/off) 0.500x (50.0% faster)
Image applyMask (SIMD off) 391.000 ms
Image applyMask (SIMD on) 258.000 ms
Image applyMask ratio (SIMD on/off) 0.660x (34.0% faster)
Image modifyAlpha (SIMD off) 239.000 ms
Image modifyAlpha (SIMD on) 136.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.569x (43.1% faster)
Image modifyAlpha removeColor (SIMD off) 164.000 ms
Image modifyAlpha removeColor (SIMD on) 290.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 1.768x (76.8% slower)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 144 screenshots: 144 matched.
✅ Native iOS Metal screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 279 seconds

Build and Run Timing

Metric Duration
Simulator Boot 56000 ms
Simulator Boot (Run) 0 ms
App Install 11000 ms
App Launch 1000 ms
Test Execution 366000 ms

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 55ms / native 3ms = 18.3x speedup
SIMD float-mul (64K x300) java 54ms / native 3ms = 18.0x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path active (NEON-accelerated)
Base64 CN1 encode 160.000 ms
Base64 CN1 decode 127.000 ms
Base64 native encode 802.000 ms
Base64 encode ratio (CN1/native) 0.200x (80.0% faster)
Base64 native decode 376.000 ms
Base64 decode ratio (CN1/native) 0.338x (66.2% faster)
Base64 SIMD encode 49.000 ms
Base64 encode ratio (SIMD/CN1) 0.306x (69.4% faster)
Base64 SIMD decode 45.000 ms
Base64 decode ratio (SIMD/CN1) 0.354x (64.6% faster)
Base64 encode ratio (SIMD/native) 0.061x (93.9% faster)
Base64 decode ratio (SIMD/native) 0.120x (88.0% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 18.000 ms
Image createMask (SIMD on) 70.000 ms
Image createMask ratio (SIMD on/off) 3.889x (288.9% slower)
Image applyMask (SIMD off) 216.000 ms
Image applyMask (SIMD on) 137.000 ms
Image applyMask ratio (SIMD on/off) 0.634x (36.6% faster)
Image modifyAlpha (SIMD off) 206.000 ms
Image modifyAlpha (SIMD on) 165.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.801x (19.9% faster)
Image modifyAlpha removeColor (SIMD off) 140.000 ms
Image modifyAlpha removeColor (SIMD on) 141.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 1.007x (0.7% slower)

@shai-almog

shai-almog commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Compared 216 screenshots: 216 matched.
✅ Native Apple Watch (watchOS, Core Graphics) screenshot tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant