fix: flaky PII test when Faker generates short member names#2673
Open
mroderick wants to merge 1 commit into
Open
fix: flaky PII test when Faker generates short member names#2673mroderick wants to merge 1 commit into
mroderick wants to merge 1 commit into
Conversation
The test checks error logs exclude the member's name, but Faker can generate names as short as 3 chars (e.g. Man) that happen to be substrings of other words in the log message (InvitationManager). Use word-boundary regex instead of substring include. Refs: https://github.com/codebar/planner/actions/runs/28191685483
KimberleyCook
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failure in PR #2672 (https://github.com/codebar/planner/actions/runs/28191685483/job/83507647002?pr=2672).
Root cause: test checks
not_to include(member.name)— Faker generated "Man" (3 chars), which is a substring of "Manager" inInvitationManager. False positive despite no actual PII leak.Fix: use
\bword boundary regex so only a standalone name triggers the check.