Windows support for agent process detection (replace ps/lsof/pwdx with PowerShell CIM)#114
Open
mvanhorn wants to merge 1 commit into
Open
Windows support for agent process detection (replace ps/lsof/pwdx with PowerShell CIM)#114mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
…h PowerShell CIM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent process detection now works on Windows: the process-enumeration utility uses PowerShell on Windows instead of the Unix
ps/lsofpath, so agent sessions are detected on Windows hosts as they already are on macOS and Linux.Why this matters
The detection utility shelled out to
psandlsof, which do not exist on Windows, so agent detection silently returned nothing there. Adding a Windows branch that queries the same information via PowerShell makes the feature cross-platform. Reported in #113.Testing
The existing process tests are pinned to a POSIX platform and a Windows-path test set was added, so the suite passes on both POSIX and Windows runners. The package builds.
Closes #113
AI was used for assistance.