Skip to content

test(plugin-lighthouse): fix test assertion link style change#1166

Closed
matejchalk wants to merge 1 commit into
mainfrom
fix-lighthouse-unit-test
Closed

test(plugin-lighthouse): fix test assertion link style change#1166
matejchalk wants to merge 1 commit into
mainfrom
fix-lighthouse-unit-test

Conversation

@matejchalk

@matejchalk matejchalk commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

A broken test was merged in #1164. Weirdly, the CI didn't catch it, remote cache was used when it should've been invalidated 😬

The Code PushUp jobs in this PR are failing in the main branch because of the broken test.

@nx-cloud

nx-cloud Bot commented Dec 4, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d7990fc

Command Status Duration Result
nx run-many --targets=code-pushup --parallel=fa... ❌ Failed 7s View ↗
nx run-many -t unit-test,int-test ❌ Failed 6s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-04 09:17:31 UTC

@pkg-pr-new

pkg-pr-new Bot commented Dec 4, 2025

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1166

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1166

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1166

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1166

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1166

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1166

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1166

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1166

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1166

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1166

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1166

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1166

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1166

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1166

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1166

commit: d7990fc

@matejchalk matejchalk marked this pull request as ready for review December 4, 2025 09:04
@matejchalk matejchalk requested a review from BioPhoton as a code owner December 4, 2025 09:04
@matejchalk

Copy link
Copy Markdown
Collaborator Author

Just noticed this is already being fixed by #1165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant