cpi images: enable ssh --director

[aramprice]

Add ENV vars necessary to enable bosh ssh --director to work from CPI container images (docker, warden).

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Walkthrough

Both ci/dockerfiles/docker-cpi/start-bosh.sh and ci/dockerfiles/warden-cpi/start-bosh.sh were modified to fetch additional director credentials from creds.yml: an Mbus bootstrap TLS certificate and password. These scripts now export two additional environment variables, BOSH_AGENT_CERTIFICATE and BOSH_AGENT_ENDPOINT, into their respective generated environment files (bosh-env and local_bosh_dir/env). BOSH_AGENT_ENDPOINT is constructed as an HTTPS Mbus URL incorporating the fetched bootstrap password and director IP/port. No exported or public entity declarations were changed.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is a single line and omits all required template sections.	Fill out the template sections for change summary, context, tests, release notes, breaking changes, and tags.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: enabling ssh --director for CPI images.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cpi-image-enable-director-ssh

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/dockerfiles/docker-cpi/start-bosh.sh`:
- Line 274: The BOSH_AGENT_ENDPOINT export in the startup script writes
mbus_bootstrap_pass directly into a sourced env file, so special characters can
break the shell assignment or URL userinfo parsing. Update the logic around the
BOSH_AGENT_ENDPOINT echo to escape/encode mbus_bootstrap_pass before writing it,
and make the same change in the matching start-bosh.sh used by the warden CPI.
Use the existing variable flow from mbus_bootstrap_pass to the export line so
the fix applies consistently wherever the sourced env file is generated.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fdc920ef-8330-4275-8d84-914725973c36

📥 Commits

Reviewing files that changed from the base of the PR and between d1ce40a and f3bd15e.

📒 Files selected for processing (2)

• ci/dockerfiles/docker-cpi/start-bosh.sh
• ci/dockerfiles/warden-cpi/start-bosh.sh