Skip to content

[Logs] Update Logpush dataset field definitions (2026-06-22)#31626

Open
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-22
Open

[Logs] Update Logpush dataset field definitions (2026-06-22)#31626
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-22

Conversation

@soheiokamoto

Copy link
Copy Markdown
Contributor

Summary

Automated sync of Logpush dataset field definitions from data/entities.

New datasets

  • WebSocket Analytics: A new dataset with fields including BytesReceivedClient, BytesReceivedOrigin, BytesSentClient, BytesSentOrigin, ClientASN, ClientIP, ClientRequestHost, ClientRequestPath, ClientRequestUserAgent, ColoCode, ConnectionCloseReason, ConnectionCloseSource, ConnectionID, ConnectionTransportCloseCode, EdgeEndTimestamp, EdgeStartTimestamp, and RayID.
  • WebSocket Analytics: A new dataset with fields including BytesReceivedClient, BytesReceivedOrigin, BytesSentClient, BytesSentOrigin, ClientASN, ClientIP, ClientRequestHost, ClientRequestPath, ClientRequestUserAgent, ColoCode, ConnectionCloseReason, ConnectionCloseSource, ConnectionID, ConnectionTransportCloseCode, EdgeEndTimestamp, EdgeStartTimestamp, and RayID.

Updated fields in existing datasets

  • Email Security Alerts (added): BCC, DKIMResult, DMARCPolicy, DMARCResult, and SPFResult.
  • Firewall events (added): ZoneName.

Files changed

  • src/content/docs/logs/logpush/logpush-job/datasets/account/ — dataset pages
  • src/content/docs/logs/logpush/logpush-job/datasets/zone/ — dataset pages
  • src/content/changelog/logs/2026-06-22-log-fields-updated.mdx — changelog

Documentation checklist

  • Changelog entry added
  • Content generated by code generator (DO NOT EDIT manually)

@soheiokamoto

Copy link
Copy Markdown
Contributor Author

/bonk please review this automated sync of Logpush dataset field definitions.

Focus on the following:

  1. Changelog quality — is the entry clear, accurate, and useful to end users?

  2. Field description quality — are the descriptions accurate, clear, and complete?

  3. Manual edits at risk of being overwritten — are there any field descriptions that appear
    to have been manually edited directly in cloudflare-docs (e.g. contain context or guidance
    not present in the machine-generated description format)? If so, flag them so the author can
    preserve those edits in the internal source YAML.

@soheiokamoto soheiokamoto requested review from a team and rianvdm as code owners June 22, 2026 17:52
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 2 warnings, 💡 1 suggestion found in commit cc79933.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
changelog/logs/2026-06-22-log-fields-updated.mdx line 12 Duplicate dataset entry — Lines 11 and 12 list the exact same WebSocket Analytics dataset and field list; the PR title says multiple new datasets, but the second bullet is a duplicate, not a distinct dataset. Fix: Replace the second bullet with the other new Logpush dataset and its fields, or remove the duplicate.

Style Guide Review

Warnings (1)
File Issue
changelog/logs/2026-06-22-log-fields-updated.mdx line 9 Headings must be sequential — Body starts with ### New datasets, skipping H2 after the frontmatter title renders H1 Fix: Use ## New datasets to keep heading levels sequential
Suggestions (1)
File Issue
changelog/logs/2026-06-22-log-fields-updated.mdx line 16 Bulleted list with fewer than three items — Only two bullet items under ### Updated fields in existing datasets Fix: Consider rewriting the two items as prose instead of a bullet list
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/docs/logs/ @soheiokamoto, @angelampcosta, @rianvdm, @dcpena, @cloudflare/product-owners

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated sync of Logpush dataset field definitions.

Changes:

  • Adds WebSocket Analytics dataset pages for both account and zone scope.
  • Adds BCC, DKIMResult, DMARCPolicy, DMARCResult, and SPFResult to Email Security Alerts.
  • Adds ZoneName to Firewall events.
  • Adds changelog entry for 2026-06-22.

2 issues need fixing before merge:

  • CRITICAL src/content/changelog/logs/2026-06-22-log-fields-updated.mdx:12 — Duplicate "WebSocket Analytics" bullet. Remove the duplicate line.
  • MEDIUM src/content/changelog/logs/2026-06-22-log-fields-updated.mdx:2 — Title is redundant ("datasets" appears three times). Tighten the title.

No manual edits appear at risk of being overwritten.

@@ -0,0 +1,19 @@
---
title: New Logpush datasets and updated fields across multiple Logpush datasets in Cloudflare Logs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tighten to avoid repeating "datasets":

Suggested change
title: New Logpush datasets and updated fields across multiple Logpush datasets in Cloudflare Logs
title: New and updated Logpush dataset fields in Cloudflare Logs

### New datasets

- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.
- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this duplicate bullet. WebSocket Analytics is already listed on the preceding line.

@ask-bonk

ask-bonk Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review posted on PR #31626.

What I did:

  • Applied label: product:logs
  • Posted a review with REQUEST_CHANGES and 2 inline comments.

Summary of changes:

  • Adds WebSocket Analytics dataset pages for both account and zone scope.
  • Adds BCC, DKIMResult, DMARCPolicy, DMARCResult, and SPFResult fields to Email Security Alerts.
  • Adds ZoneName field to Firewall events.
  • Adds a changelog entry for 2026-06-22.

Issues flagged:

Severity File Issue
CRITICAL src/content/changelog/logs/2026-06-22-log-fields-updated.mdx:12 Duplicate "WebSocket Analytics" bullet — same entry appears twice in the "New datasets" section.
MEDIUM src/content/changelog/logs/2026-06-22-log-fields-updated.mdx:2 Changelog title is redundant ("datasets" appears three times); suggested a tighter version inline.

Field descriptions are clear, consistent with existing generated format, and no manual edits appear at risk of being overwritten by future syncs.

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants