Skip to content

LITE-33042 Support monthly_trial billing period#246

Draft
pcaro wants to merge 2 commits into
masterfrom
LITE-33042-support-monthly-trial-billing-period
Draft

LITE-33042 Support monthly_trial billing period#246
pcaro wants to merge 2 commits into
masterfrom
LITE-33042-support-monthly-trial-billing-period

Conversation

@pcaro

@pcaro pcaro commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • Add monthly_trial to the BILLING_PERIOD tuple in constants.py
  • Add monthly_trial: ('-',) to ALLOWED_COMMITMENTS (trial periods allow no long-term commitment)
  • Fix _get_billing_period() to pass monthly_trial through as-is (prevents crash on space-split for multi-year conversion)

Test plan

  • poetry run pytest tests/plugins/product/sync/test_items.py -x -q — all pass
  • Updated test_validate_wrong_period_reservation expected error message to include monthly_trial
  • New test test_validate_monthly_trial_period_wrong_commitment covers commitment restriction
  • Manually clone a product with monthly_trial items and confirm 0 errors

Closes LITE-33042

🤖 Generated with Claude Code

Add monthly_trial to the allowed BILLING_PERIOD values so products
with items using this period can be cloned without errors. Commitments
are restricted to '-' only (no long-term commitment for trial periods).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Pablo Caro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Cover the _get_billing_period pass-through for monthly_trial to meet
SonarCloud coverage threshold on new code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants