Skip to content

Update config.go#528

Closed
yuvarajrece wants to merge 4 commits into
civo:masterfrom
yuvarajrece:patch-3
Closed

Update config.go#528
yuvarajrece wants to merge 4 commits into
civo:masterfrom
yuvarajrece:patch-3

Conversation

@yuvarajrece

Copy link
Copy Markdown
Contributor

Add config option to disable github version checks #313

Added a new flag DisableVersionCheck to the metadata struct.

Modified CivoAPIClient to check DisableVersionCheck before making API calls.

Updated loadConfig to ensure the version check only happens if DisableVersionCheck is false.

Updated saveUpdatedConfig to properly serialize the modified config.

Add config option to disable github version checks civo#313


Added a new flag DisableVersionCheck to the metadata struct.

Modified CivoAPIClient to check DisableVersionCheck before making API calls.

Updated loadConfig to ensure the version check only happens if DisableVersionCheck is false.

Updated saveUpdatedConfig to properly serialize the modified config.
@giornetta giornetta requested review from fulviodenza and giornetta May 6, 2025 07:30
@giornetta giornetta added the enhancement New feature or request label May 6, 2025

@fulviodenza fulviodenza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please remove first the comments. I'll give it a look ASAP

Comment thread config/config.go Outdated
@yuvarajrece

yuvarajrece commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@fulviodenza @giornetta Comments cleared, please review

@giornetta

Copy link
Copy Markdown
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants