test: remove timeout from pop_sent_msg_ex()#8331
Merged
Merged
Conversation
Collaborator
Author
link2xt
force-pushed
the
link2xt/pop_sent_msg-no-timeout
branch
from
2f33849 to
600e280
Compare
link2xt
changed the title
Collaborator
Author
|
Might be easier to merge this and rebase #8008 though. |
iequidoo
approved these changes
Jun 13, 2026
Arbitrary timeouts often result in flaky tests, especially if CI runners may be paused. In this case however timeout was not used by any tests and only slowed down the tests in cases where no message is expected but non-zero timeout is set.
link2xt
force-pushed
the
link2xt/pop_sent_msg-no-timeout
branch
from
600e280 to
000270f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arbitrary timeouts often result in flaky tests,
especially if CI runners may be paused.
In this case however timeout was not used by any tests and only slowed down the tests in cases where
no message is expected but non-zero timeout is set.