ENT-14169: Fixed cf-postgres.service race in hub postinstall DB setup#2292
Draft
aleksandrychev wants to merge 1 commit into
Draft
ENT-14169: Fixed cf-postgres.service race in hub postinstall DB setup#2292aleksandrychev wants to merge 1 commit into
aleksandrychev wants to merge 1 commit into
Conversation
The %post scriptlet starts its own PostgreSQL instance to initialize/migrate database, but cf-postgres.service has `Restart=always`, so systemd races it for port 5432 and the data directory. The scriptlet's subsequent `pg_ctl stop` fails with `PID file does not exist` and aborts under `set -e`. Ticket: ENT-14169 Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Contributor
Author
|
@cf-bottom jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13929/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13929/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The %post scriptlet starts its own PostgreSQL instance to initialize/migrate database, but cf-postgres.service has
Restart=always, so systemd races it for port 5432 and the data directory. The scriptlet's subsequentpg_ctl stopfails withPID file does not existand aborts underset -e.Ticket: ENT-14169