refactor(devnet): Configure sequential tasks and exit on error#481
Merged
Conversation
…ner to exit on error. * Dependencies task download and extract artifacts information. The change prevents race-condition errors that cause EEXIST and ENOENT errors. * Set task runner to exit on error. That change is targeting the release CI action to avoid publishing a package with missing data.
🦋 Changeset detectedLatest commit: 7c5511c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to stop publishing of now-considered-incomplete builds and also to avoid race conditions in the
dependenciestask, which downloads and extracts artefact information. After the release/publishing of versionalpha.12, the expected testnet and mainnet deployment information was missing. Through careful checking in the release action:8:43, anEEXISTfollowed by anENOENTerror was logged.In more detail, local replication is not 100% guaranteed due to timing, but it occurs not only in the temporary folder
build/but also a few times in theout/folder, as the build process flattens content and puts it together for subsequent tasks to consume.As a result, the download and extraction tasks now run sequentially, and the Task runner is explicitly instructed to exit on error.