fix: improve Android snapshot fidelity#580
Open
thymikee wants to merge 1 commit into
Open
Conversation
|
thymikee
force-pushed
the
codex/android-snapshot-fidelity
branch
2 times, most recently
from
eeb8662 to
ec3e5c5
Compare
thymikee
force-pushed
the
codex/android-snapshot-fidelity
branch
from
ec3e5c5 to
3645382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve Android helper snapshots so
snapshot -ikeeps useful UI semantics while removing helper noise: row labels are promoted, duplicate structural nodes are collapsed, and hidden scroll-area hints render at the top/bottom of the relevant scroll content.Fix Android screenshot overlay refs to use screenshot pixel coordinates, trim overly tall unlabeled row refs, and include visible unlabeled bottom-tab controls without inventing labels.
Touched 13 files; scope stayed within Android snapshot presentation, generic snapshot text rendering, screenshot overlay refs, and focused tests.
Validation
pnpm formatpassed.pnpm exec vitest run src/utils/__tests__/output.test.tspassed: 35 tests.pnpm exec vitest run src/daemon/__tests__/screenshot-overlay.test.ts src/daemon/__tests__/snapshot-processing.test.tspassed: 17 tests.pnpm check:fallow --base origin/mainpassed.pnpm check:quickpassed.pnpm buildpassed.git diff --checkpassed.Manual Android verification covered built-in apps, YouTube, Expensify, and the test app across multiple screens with
snapshot -i,snapshot --raw, andscreenshot --overlay-refs. Raw snapshots still preserve the original helper data; the compact text snapshots are less ambiguous. Test-app bottom tabs are now represented as clickable refs. The Expo debug cog is present only as anonymous non-hittable raw nodes, so it is not emitted as a clickable overlay ref.pnpm check:unitwas rerun outside the sandbox: 209/211 test files passed, 1801/1803 tests passed. The remaining failures are pre-existing/unrelated:src/utils/__tests__/video.test.tsMP4 fallback validation returnsfalsewhen Swift is unavailable, andsrc/platforms/android/__tests__/index.test.tstimes out in the.aabbundletool install test.