Skip to content

[46.0 backport] Add explicit hint for generic call (#13715)#13719

Merged
pchickey merged 1 commit into
bytecodealliance:release-46.0.0from
Mark-Simulacrum:backport-13715
Jun 24, 2026
Merged

[46.0 backport] Add explicit hint for generic call (#13715)#13719
pchickey merged 1 commit into
bytecodealliance:release-46.0.0from
Mark-Simulacrum:backport-13715

Conversation

@Mark-Simulacrum

Copy link
Copy Markdown
Contributor

This backports #13715 (hope I did this right).

cc @pchickey

* Hint generics in add_to_linker_instance

This fixes compilation with the new trait solver (probably an upstream
bug, haven't checked, but this is a trivial workaround). See compilation
failure here: rust-lang/rust#157590 (comment)

* Fix fallout in tests from additional hinting
@Mark-Simulacrum Mark-Simulacrum requested a review from a team as a code owner June 23, 2026 23:19
@Mark-Simulacrum Mark-Simulacrum requested review from pchickey and removed request for a team June 23, 2026 23:19
@Mark-Simulacrum Mark-Simulacrum changed the title Add explicit hint for generic call (#13715) [46.0 backport] Add explicit hint for generic call (#13715) Jun 23, 2026
@pchickey pchickey enabled auto-merge (squash) June 23, 2026 23:35
@Mark-Simulacrum

Copy link
Copy Markdown
Contributor Author

CI failure is presumably spurious, I don't think this change could have broken s390x specifically? I don't think I have permissions to retry though.

@pchickey

Copy link
Copy Markdown
Contributor

I'm not familiar with that test and don't have bandwidth to dig in today, so I hit rerun failed jobs, and filed #13720 so Alex can take a look when he has time.

auto-merge was automatically disabled June 24, 2026 16:14

Pull request was closed

@pchickey pchickey merged commit 311587e into bytecodealliance:release-46.0.0 Jun 24, 2026
957 of 965 checks passed
pchickey added a commit to pchickey/wasmtime that referenced this pull request Jun 24, 2026
@Mark-Simulacrum Mark-Simulacrum deleted the backport-13715 branch June 24, 2026 17:02
pchickey added a commit that referenced this pull request Jun 24, 2026
* Increase timeout for `p3_cli_stdout_flush` (#13670)

Turns out s390x emulation can be quite slow, so prevent spurious
failures by increasing the timeout.

* add #13719 to release-46 RELEASES

---------

Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants