[GRO-1908] Make missing daemon errors actionable#2356
Draft
Kylejeong2 wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: b1d217f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECONNREFUSEDandENOENTfailures into a human-readable errorbrowse opencommand that restarts the requested sessionbrowse stopis idempotentRoot cause
The daemon client passed raw Unix socket errors through to users when the daemon disappeared between the readiness check and the request. Agents received
ECONNREFUSEDwithout a recovery command.Impact
Agents now get an actionable
daemon_not_runningfailure with the exact command needed to restart the session. The bundled SKILL.md also makes the already-fixed env timing and stop behavior explicit.Validation
pnpm turbo run build --filter=browse...pnpm --dir packages/cli exec vitest run tests/driver-foundation.test.ts tests/daemon-forwarded-env-drift.test.ts(36 tests)pnpm --dir packages/cli checkpnpm --dir packages/cli format:checkpnpm --dir packages/cli eslintLinear: GRO-1908
Summary by cubic
Make missing daemon errors actionable by replacing raw socket failures with a clear
daemon_not_runningmessage that includes the exactbrowse opencommand for the session. Addresses Linear: https://linear.app/browserbase/issue/GRO-1908/cli-namespace-2027-dev-suggested-docs-updates.ECONNREFUSED/ENOENTtodaemon_not_runningand print the exactbrowse opencommand (session-aware, preserves URL quoting).BROWSERBASE_API_KEYis forwarded on every command and thatbrowse stopis idempotent (exit code 0 when nothing to stop).Written for commit b1d217f. Summary will update on new commits.