[STG-2529] fix(openclaw-browserbase): repoint skill sync to browse-plugin#87
Open
shrey150 wants to merge 1 commit into
Open
[STG-2529] fix(openclaw-browserbase): repoint skill sync to browse-plugin#87shrey150 wants to merge 1 commit into
shrey150 wants to merge 1 commit into
Conversation
skills-sync.ts pulled the browser-automation skill from browserbase/skills, which references the deprecated @browserbasehq/browse-cli install command. browserbase/browse-plugin's skills/browse/SKILL.md is the current, actively-maintained source (same top-level skills/ extraction convention, so this is a URL swap, not a mechanism change). Verified live against both refs before writing this: main (no skills/ dir yet, browse-plugin#3 unmerged) fails with "Tarball extracted zero files under the skills/ prefix"; the shrey/all-marketplace-manifests branch (previewing post-merge main) succeeds and extracts exactly browse/SKILL.md. This PR must merge after browse-plugin#3, not before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1e9c6c. Configure here.
|
|
||
| const TARBALL_BASE = 'https://codeload.github.com/browserbase/skills/tar.gz'; | ||
| const TARBALL_BASE = | ||
| 'https://codeload.github.com/browserbase/browse-plugin/tar.gz'; |
There was a problem hiding this comment.
Stale skills block auto-sync
Medium Severity
After repointing to the browse skill, hasBrowserbaseSkills still treats any directory with a SKILL.md as installed. Existing users who already synced the old skills keep those stale files, so startup auto-sync never fetches browse, and status keeps reporting skills as installed.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d1e9c6c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Linear: STG-2529
What
@browserbasehq/openclaw-browserbase's dynamic skill sync (skills-sync.ts) pulled thebrowser-automationskill frombrowserbase/skills, which is stale — it references the deprecated@browserbasehq/browse-cliinstall command. This repoints it tobrowserbase/browse-plugin's currentskills/browse/SKILL.md, the actively-maintained source for thebrowseCLI skill.Both repos use the same top-level
skills/extraction convention, so this is a URL swap inTARBALL_BASEplus updated user-facing strings/docs (src/index.ts,README.md) — no change to the sync mechanism itself.browserbase/browse-plugin#3 is what adds a top-level
skills/browse/directory tobrowse-plugin'smain(currently still the old nestedplugins/browse/skills/browse/layout, pre-flatten). Until #3 merges, this PR's new sync target has noskills/dir at the repo root, andopenclaw browserbase skills syncwill fail loudly (verified below) instead of silently succeeding wrong — but it will still be a real regression for the ~180 monthly downloads of this package if merged first.Recommended sequencing: merge browse-plugin#3, then this PR.
E2E Test Matrix
pnpm run check-types(this package)pnpm run buildsyncBrowserbaseSkills({ ref: 'main' })againstbrowserbase/browse-pluginmain, run against the builtdist/skills-sync.jsTarball extracted zero files under the skills/ prefix.browse-plugin, and confirms the merge-order dependency above is real, not theoretical.syncBrowserbaseSkills({ ref: 'shrey/all-marketplace-manifests' })— the branch that becomesmainonce #3 mergesfilesWritten: ['<tmp>/browse/SKILL.md']grep -rn "browserbase/skills" src/ README.mdTest artifacts (
/tmp/oc-sync-test-*) cleaned up after; no leftover state in the repo.🤖 Generated with Claude Code
Note
Medium Risk
Skill sync behavior changes for all setup/startup flows; merging before browse-plugin exposes the new
skills/layout can break sync for existing users until upstream lands.Overview
Dynamic skill sync for
@browserbasehq/openclaw-browserbasenow pulls frombrowserbase/browse-plugininstead of the stalebrowserbase/skillsrepo. The tarball URL inskills-sync.ts(TARBALL_BASE) is the functional change; extraction still uses the sameskills/prefix and strip logic, now documented forbrowse-plugin-<sha>/skills/browse/.User-facing strings in
src/index.ts(setup,skills sync, startup auto-sync logs and CLI help) andREADME.mddescribe the new source and the canonicalbrowseskill instead ofbrowser-automation/functions. A patch changeset records the package bump.Deploy note: sync against
browse-pluginmainonly works once that repo has a root-levelskills/tree (per upstream PR); until then,skills synccan fail with “zero files under the skills/ prefix.”Reviewed by Cursor Bugbot for commit d1e9c6c. Bugbot is set up for automated code reviews on this repo. Configure here.