Skip to content

fix(auth): gracefully re-prompt on empty email during login #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theFong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): gracefully re-prompt on empty email during login #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/auth/kas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,14 @@ func (a KasAuthenticator) maybePromptForEmail() (string, error) {
} else if a.Email != "" {
return a.Email, nil
} else {
t := terminal.New()
fmt.Print(t.Green("Enter your email: "))
_, err := fmt.Scanln(&email)
if err != nil {
return "", breverrors.WrapAndTrace(err)
}
}
return email, nil
// PromptGetInput validates and re-prompts on empty input, so hitting
// enter with no email no longer surfaces a raw "unexpected newline" error.
email = terminal.PromptGetInput(terminal.PromptContent{
Label: "Enter your email:",
ErrorMsg: "please enter a valid email address",
})
}
return strings.TrimSpace(email), nil
}

func (a KasAuthenticator) pollForTokens(sessionKey, id string) (*LoginTokens, error) {
Expand Down
Loading