Syncling: Auto-Translations for 26c17f9#177
Closed
bosankus wants to merge 1 commit into
Closed
Conversation
Contributor
📝 WalkthroughWalkthroughFour new Android string resource files are added for Hindi ( ChangesLocale String Resources
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@values-ko/strings.xml`:
- Around line 1-68: The values-ko/strings.xml file is missing 6 string resource
definitions that are actively referenced in the application code, which will
cause MissingResourceException crashes at runtime for Korean locale users. Add
the missing string resources with appropriate Korean translations for:
confirm_btn_txt, language_screen_title, network_unavailable_txt,
place_search_dialog_title, settings_language_txt, and
settings_notifications_txt. Reference the Hindi or Thai translation files as
examples to match the formatting and ensure the Korean translations are accurate
and contextually appropriate for the application features these strings support.
In `@values-th/strings.xml`:
- Around line 1-73: The Thai translation file values-th/strings.xml is missing
the network_unavailable_txt string resource key which causes a
MissingResourceException when the app tries to access it for Thai locale users.
Add the missing network_unavailable_txt string entry to the
values-th/strings.xml file between the XML opening tag and the closing resources
tag, using a Thai translation that conveys the message about network being
unavailable. Reference the Hindi values file to see the original
network_unavailable_txt string if needed to understand the intended meaning and
ensure consistency with the app's messaging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a0a15fb-58e8-4a09-abc2-96f4172ad1ec
📒 Files selected for processing (4)
values-hi/strings.xmlvalues-ko/strings.xmlvalues-pt-rBR/strings.xmlvalues-th/strings.xml
Comment on lines
+1
to
+68
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <string name="network_timeout_txt">요청 시간이 초과되었습니다. 나중에 다시 시도해 주세요.</string> | ||
| <string name="gps_disabled_error_txt">위치 서비스가 꺼져 있습니다. 현지 날씨 정보를 확인하려면 GPS를 활성화해 주세요.</string> | ||
| <string name="enable_gps_btn_txt">GPS 활성화</string> | ||
| <string name="profile_title">프로필</string> | ||
| <string name="logout_btn_txt">로그아웃</string> | ||
| <string name="logout_confirmation_txt">정말 로그아웃하시겠습니까?</string> | ||
| <string name="logout_warning_txt">계정에 액세스하려면 다시 로그인해야 합니다.</string> | ||
| <string name="cancel_btn_txt">취소</string> | ||
| <string name="premium_get_txt">프리미엄 구매</string> | ||
| <string name="premium_processing_txt">처리 중…</string> | ||
| <string name="premium_processing_desc_txt">프리미엄 구독을 활성화하는 동안 잠시만 기다려 주세요.</string> | ||
| <string name="premium_unlock_desc_txt">모든 기능을 잠금 해제하고 광고 없는 경험을 즐기세요.</string> | ||
| <string name="premium_upgrade_btn_txt">지금 업그레이드</string> | ||
| <string name="premium_active_txt">프리미엄 사용자입니다</string> | ||
| <string name="premium_expires_txt">만료일 %1$s</string> | ||
| <string name="premium_active_status_txt">활성</string> | ||
| <string name="premium_activated_title_txt">프리미엄 활성화됨</string> | ||
| <string name="premium_activated_msg_txt">프리미엄 구독이 활성화되었습니다!</string> | ||
| <string name="legal_privacy_policy_txt">개인정보 처리방침</string> | ||
| <string name="legal_terms_of_use_txt">이용약관</string> | ||
| <string name="legal_app_version_txt">앱 버전</string> | ||
| <string name="settings_section_title">설정</string> | ||
| <string name="legal_section_title">법률</string> | ||
| <string name="back_button_content">뒤로 가기 버튼</string> | ||
| <string name="notification_icon_content">알림 설정 아이콘</string> | ||
| <string name="privacy_icon_content">개인정보 처리방침 아이콘</string> | ||
| <string name="terms_icon_content">이용약관 아이콘</string> | ||
| <string name="info_icon_content">정보 아이콘</string> | ||
| <string name="arrow_right_icon_content">다음 화면으로 이동</string> | ||
| <string name="locale_config_error_txt">언어 구성을 불러오지 못했습니다. 기본 언어를 사용합니다.</string> | ||
| <string name="notification_permission_title">최신 정보 받기</string> | ||
| <string name="notification_permission_message">날씨 알림을 받으려면 알림을 활성화하세요</string> | ||
| <string name="enable_notification_btn">활성화</string> | ||
| <string name="language_lib_screen_header">언어 선택</string> | ||
| <string name="language_back_content_description">뒤로 가기</string> | ||
| <string name="language_screen_subtitle">개인화된 경험을 위해 선호하는 언어를 선택하세요</string> | ||
| <string name="language_selected">%s 선택됨</string> | ||
| <string name="language_navigate_back">뒤로 이동</string> | ||
| <string name="saved_locations_screen">저장된 위치</string> | ||
| <string name="saved_locations_title">저장된 위치</string> | ||
| <string name="saved_locations_empty_txt">아직 저장된 위치가 없습니다. +를 눌러 추가하세요.</string> | ||
| <string name="saved_locations_add_btn">위치 추가</string> | ||
| <string name="saved_locations_delete_btn">삭제</string> | ||
| <string name="saved_locations_save_btn">저장</string> | ||
| <string name="saved_locations_name_hint">위치 이름 (예: 집)</string> | ||
| <string name="saved_locations_premium_title">프리미엄 기능</string> | ||
| <string name="saved_locations_premium_desc">즐겨찾는 위치를 저장하고 즉시 확인하세요. 프리미엄으로 업그레이드하여 이 기능을 잠금 해제하세요.</string> | ||
| <string name="saved_locations_error_txt">저장된 위치를 불러오지 못했습니다.</string> | ||
| <string name="saved_locations_save_success">위치가 성공적으로 저장되었습니다.</string> | ||
| <string name="saved_locations_delete_success">위치가 삭제되었습니다.</string> | ||
| <string name="saved_locations_icon_content">저장된 위치</string> | ||
| <string name="add_icon_content">새 위치 추가</string> | ||
| <string name="delete_icon_content">위치 삭제</string> | ||
| <string name="set_as_default_dialog_title">날씨 위치로 사용하시겠습니까?</string> | ||
| <string name="set_as_default_dialog_body">현재 GPS 위치 대신 %1$s의 날씨 데이터가 표시됩니다.</string> | ||
| <string name="set_as_default_dialog_warning">이 기능이 활성화되어 있는 동안에는 실시간 GPS 위치가 업데이트되지 않습니다.</string> | ||
| <string name="set_as_default_confirm_btn">기본값으로 설정</string> | ||
| <string name="location_override_chip_label">%1$s 사용 중</string> | ||
| <string name="location_override_reset_btn">GPS로 재설정</string> | ||
| <string name="location_override_chip_content_desc">현재 %1$s의 날씨가 표시되고 있습니다. GPS로 재설정하려면 탭하세요.</string> | ||
| <string name="place_search_hint">도시 또는 주소 입력…</string> | ||
| <string name="place_search_no_results">'%1$s'에 대한 검색 결과가 없습니다.</string> | ||
| <string name="general_error_txt">죄송합니다. 문제가 발생했습니다.</string> | ||
| <string name="empty_city_list_error_txt">오류가 발생했습니다! 현재 찾을 수 있는 도시가 없습니다. 나중에 다시 확인해 주세요.</string> | ||
| <string name="empty_list">세부 정보를 찾을 수 없습니다. 잠시 후 다시 시도하세요.</string> | ||
| </resources> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check which string keys exist in Hindi but are missing in Korean
echo "=== Keys in Hindi but missing in Korean ==="
rg 'name="([^"]+)"' -o -r '$1' values-hi/strings.xml | sort > /tmp/hi_keys.txt
rg 'name="([^"]+)"' -o -r '$1' values-ko/strings.xml | sort > /tmp/ko_keys.txt
comm -23 /tmp/hi_keys.txt /tmp/ko_keys.txt
echo ""
echo "=== Total counts ==="
echo "Hindi entries: $(wc -l < /tmp/hi_keys.txt)"
echo "Korean entries: $(wc -l < /tmp/ko_keys.txt)"Repository: bosankus/Compose-Weatherify
Length of output: 311
🏁 Script executed:
# Check if any of the missing keys are referenced in the application code
echo "=== Searching for references to missing keys in application code ==="
for key in confirm_btn_txt language_screen_title network_unavailable_txt place_search_dialog_title settings_language_txt settings_notifications_txt; do
count=$(rg "stringResource.*$key|R\.string\.$key" --count --count-matches 2>/dev/null | head -1)
if [ -n "$count" ] && [ "$count" -gt 0 ]; then
echo "Key '$key' found: $count references"
rg "stringResource.*$key|R\.string\.$key" -A 2 -B 2 | head -10
else
echo "Key '$key': not found in code"
fi
doneRepository: bosankus/Compose-Weatherify
Length of output: 1267
🏁 Script executed:
# Check if Portuguese and Thai files have these missing keys
echo "=== Checking Portuguese translation ==="
rg 'name="(confirm_btn_txt|language_screen_title|network_unavailable_txt|place_search_dialog_title|settings_language_txt|settings_notifications_txt)"' values-pt/ 2>/dev/null | wc -l
echo "=== Checking Thai translation ==="
rg 'name="(confirm_btn_txt|language_screen_title|network_unavailable_txt|place_search_dialog_title|settings_language_txt|settings_notifications_txt)"' values-th/ 2>/dev/null | wc -l
echo "=== List of all translation files available ==="
fd -t d "values-" --max-depth 1Repository: bosankus/Compose-Weatherify
Length of output: 245
🏁 Script executed:
# Determine which of the 6 missing keys Thai HAS
echo "=== Thai file entries for the 6 keys ==="
rg 'name="(confirm_btn_txt|language_screen_title|network_unavailable_txt|place_search_dialog_title|settings_language_txt|settings_notifications_txt)"' values-th/strings.xml
echo ""
echo "=== Complete count comparison across all languages ==="
for dir in values-hi values-ko values-pt-rBR values-th; do
if [ -d "$dir" ]; then
count=$(rg 'name="([^"]+)"' -o -r '$1' "$dir/strings.xml" 2>/dev/null | wc -l)
echo "$dir: $count entries"
fi
done
echo ""
echo "=== Keys in Korean vs Hindi (show first 10 differences) ==="
rg 'name="([^"]+)"' -o -r '$1' values-hi/strings.xml | sort > /tmp/hi.txt
rg 'name="([^"]+)"' -o -r '$1' values-ko/strings.xml | sort > /tmp/ko.txt
comm -23 /tmp/hi.txt /tmp/ko.txt | head -10Repository: bosankus/Compose-Weatherify
Length of output: 765
🏁 Script executed:
# Check if any of these keys are actually used anywhere (broader search)
echo "=== Searching entire codebase for these keys ==="
for key in confirm_btn_txt language_screen_title network_unavailable_txt place_search_dialog_title settings_language_txt settings_notifications_txt; do
echo "--- Searching for: $key ---"
rg "$key" --type kotlin --type java 2>/dev/null | head -5
doneRepository: bosankus/Compose-Weatherify
Length of output: 2141
Missing 6 string resource keys in Korean translation will cause runtime crashes.
The Korean translation file is missing 6 string keys that are actively used in the application code:
confirm_btn_txt— Used in SettingsScreenStrings.kt and AppNavigation.ktlanguage_screen_title— Used in LanguageScreenStrings.ktnetwork_unavailable_txt— Used in UiText.kt for error handling (NetworkException)place_search_dialog_title— Used in AppNavigation.kt and SavedLocationsScreenStrings.ktsettings_language_txt— Used in SettingsScreenStrings.kt and AppNavigation.ktsettings_notifications_txt— Used in SettingsScreenStrings.kt and AppNavigation.kt
These keys exist in Hindi (71 entries) and Thai (70 entries, missing only network_unavailable_txt), but Korean has only 65 entries. When the application calls stringResource(R.string.confirm_btn_txt) for a Korean locale user, it will throw MissingResourceException at runtime, crashing the settings screen and other dependent features.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@values-ko/strings.xml` around lines 1 - 68, The values-ko/strings.xml file is
missing 6 string resource definitions that are actively referenced in the
application code, which will cause MissingResourceException crashes at runtime
for Korean locale users. Add the missing string resources with appropriate
Korean translations for: confirm_btn_txt, language_screen_title,
network_unavailable_txt, place_search_dialog_title, settings_language_txt, and
settings_notifications_txt. Reference the Hindi or Thai translation files as
examples to match the formatting and ensure the Korean translations are accurate
and contextually appropriate for the application features these strings support.
Comment on lines
+1
to
+73
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <string name="network_timeout_txt">การเชื่อมต่อหมดเวลา กรุณาลองใหม่อีกครั้งในภายหลัง</string> | ||
| <string name="gps_disabled_error_txt">บริการระบุตำแหน่งถูกปิดอยู่ กรุณาเปิด GPS เพื่อรับข้อมูลสภาพอากาศในพื้นที่ของคุณ</string> | ||
| <string name="enable_gps_btn_txt">เปิดใช้งาน GPS</string> | ||
| <string name="profile_title">โปรไฟล์</string> | ||
| <string name="logout_btn_txt">ออกจากระบบ</string> | ||
| <string name="logout_confirmation_txt">คุณแน่ใจหรือไม่ว่าต้องการออกจากระบบ?</string> | ||
| <string name="logout_warning_txt">คุณจะต้องลงชื่อเข้าใช้อีกครั้งเพื่อเข้าถึงบัญชีของคุณ</string> | ||
| <string name="confirm_btn_txt">ยืนยัน</string> | ||
| <string name="cancel_btn_txt">ยกเลิก</string> | ||
| <string name="premium_get_txt">รับสถานะพรีเมียม</string> | ||
| <string name="premium_processing_txt">กำลังดำเนินการ...</string> | ||
| <string name="premium_processing_desc_txt">กรุณารอสักครู่ขณะที่เราเปิดใช้งานการสมัครสมาชิกพรีเมียมของคุณ</string> | ||
| <string name="premium_unlock_desc_txt">ปลดล็อกฟีเจอร์ทั้งหมดและเพลิดเพลินกับประสบการณ์ที่ไม่มีโฆษณาคั่น</string> | ||
| <string name="premium_upgrade_btn_txt">อัปเกรดตอนนี้</string> | ||
| <string name="premium_active_txt">คุณเป็นผู้ใช้งานระดับพรีเมียม</string> | ||
| <string name="premium_expires_txt">หมดอายุ %1$s</string> | ||
| <string name="premium_active_status_txt">ใช้งานอยู่</string> | ||
| <string name="premium_activated_title_txt">เปิดใช้งานพรีเมียมแล้ว</string> | ||
| <string name="premium_activated_msg_txt">การสมัครสมาชิกพรีเมียมของคุณเปิดใช้งานแล้ว!</string> | ||
| <string name="settings_notifications_txt">การแจ้งเตือน</string> | ||
| <string name="settings_language_txt">ภาษา</string> | ||
| <string name="legal_privacy_policy_txt">นโยบายความเป็นส่วนตัว</string> | ||
| <string name="legal_terms_of_use_txt">ข้อกำหนดการใช้งาน</string> | ||
| <string name="legal_app_version_txt">เวอร์ชันแอป</string> | ||
| <string name="settings_section_title">การตั้งค่า</string> | ||
| <string name="legal_section_title">ข้อมูลทางกฎหมาย</string> | ||
| <string name="back_button_content">ปุ่มย้อนกลับ</string> | ||
| <string name="notification_icon_content">ไอคอนการตั้งค่าการแจ้งเตือน</string> | ||
| <string name="privacy_icon_content">ไอคอนนโยบายความเป็นส่วนตัว</string> | ||
| <string name="terms_icon_content">ไอคอนข้อกำหนดการใช้งาน</string> | ||
| <string name="info_icon_content">ไอคอนข้อมูล</string> | ||
| <string name="arrow_right_icon_content">นำทางไปยังหน้าถัดไป</string> | ||
| <string name="locale_config_error_txt">ไม่สามารถโหลดการกำหนดค่าภาษาได้ กำลังใช้ภาษาเริ่มต้น</string> | ||
| <string name="notification_permission_title">อัปเดตอยู่เสมอ</string> | ||
| <string name="notification_permission_message">เปิดใช้งานการแจ้งเตือนเพื่อรับการแจ้งเตือนสภาพอากาศ</string> | ||
| <string name="enable_notification_btn">เปิดใช้งาน</string> | ||
| <string name="language_lib_screen_header">เลือกภาษา</string> | ||
| <string name="language_back_content_description">ย้อนกลับ</string> | ||
| <string name="language_screen_title">เลือกภาษาของคุณ</string> | ||
| <string name="language_screen_subtitle">เลือกภาษาที่คุณต้องการเพื่อประสบการณ์การใช้งานในแบบของคุณ</string> | ||
| <string name="language_selected">เลือก %s แล้ว</string> | ||
| <string name="language_navigate_back">ย้อนกลับ</string> | ||
| <string name="saved_locations_screen">สถานที่ที่บันทึกไว้</string> | ||
| <string name="saved_locations_title">สถานที่ที่บันทึกไว้</string> | ||
| <string name="saved_locations_empty_txt">ยังไม่มีสถานที่ที่บันทึกไว้ แตะ + เพื่อเพิ่มสถานที่</string> | ||
| <string name="saved_locations_add_btn">เพิ่มสถานที่</string> | ||
| <string name="saved_locations_delete_btn">ลบ</string> | ||
| <string name="saved_locations_save_btn">บันทึก</string> | ||
| <string name="saved_locations_name_hint">ชื่อสถานที่ (เช่น บ้าน)</string> | ||
| <string name="saved_locations_premium_title">ฟีเจอร์พรีเมียม</string> | ||
| <string name="saved_locations_premium_desc">บันทึกและเข้าถึงสถานที่โปรดของคุณได้ทันที อัปเกรดเป็นพรีเมียมเพื่อปลดล็อกฟีเจอร์นี้</string> | ||
| <string name="saved_locations_error_txt">ไม่สามารถโหลดสถานที่ที่บันทึกไว้ได้</string> | ||
| <string name="saved_locations_save_success">บันทึกสถานที่เรียบร้อยแล้ว</string> | ||
| <string name="saved_locations_delete_success">ลบสถานที่แล้ว</string> | ||
| <string name="saved_locations_icon_content">สถานที่ที่บันทึกไว้</string> | ||
| <string name="add_icon_content">เพิ่มสถานที่ใหม่</string> | ||
| <string name="delete_icon_content">ลบสถานที่</string> | ||
| <string name="set_as_default_dialog_title">ใช้เป็นสถานที่สำหรับสภาพอากาศหรือไม่?</string> | ||
| <string name="set_as_default_dialog_body">ข้อมูลสภาพอากาศจะแสดงสำหรับ %1$s แทนตำแหน่ง GPS ปัจจุบันของคุณ</string> | ||
| <string name="set_as_default_dialog_warning">ตำแหน่ง GPS จริงของคุณจะไม่ได้รับการอัปเดตในขณะที่ฟีเจอร์นี้เปิดใช้งานอยู่</string> | ||
| <string name="set_as_default_confirm_btn">ตั้งเป็นค่าเริ่มต้น</string> | ||
| <string name="location_override_chip_label">กำลังใช้ %1$s</string> | ||
| <string name="location_override_reset_btn">รีเซ็ตเป็น GPS</string> | ||
| <string name="location_override_chip_content_desc">กำลังแสดงสภาพอากาศสำหรับ %1$s แตะเพื่อรีเซ็ตกลับเป็น GPS</string> | ||
| <string name="place_search_dialog_title">ค้นหาสถานที่</string> | ||
| <string name="place_search_hint">พิมพ์ชื่อเมืองหรือที่อยู่...</string> | ||
| <string name="place_search_no_results">ไม่พบสถานที่สำหรับ '%1$s'</string> | ||
| <string name="general_error_txt">อ๊ะ!..มีบางอย่างผิดพลาด</string> | ||
| <string name="empty_city_list_error_txt">แย่แล้ว! ไม่พบเมืองในขณะนี้ โปรดตรวจสอบใหม่อีกครั้งภายหลัง</string> | ||
| <string name="empty_list">ไม่พบรายละเอียด โปรดลองใหม่อีกครั้งในภายหลัง</string> | ||
| </resources> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify which string keys differ between language files
echo "=== Keys in Hindi/Portuguese but missing in Thai ==="
rg 'name="([^"]+)"' -o -r '$1' values-hi/strings.xml | sort > /tmp/hi_keys.txt
rg 'name="([^"]+)"' -o -r '$1' values-th/strings.xml | sort > /tmp/th_keys.txt
comm -23 /tmp/hi_keys.txt /tmp/th_keys.txt
echo ""
echo "=== Total counts ==="
echo "Hindi entries: $(wc -l < /tmp/hi_keys.txt)"
echo "Thai entries: $(wc -l < /tmp/th_keys.txt)"Repository: bosankus/Compose-Weatherify
Length of output: 205
Missing 1 string resource key in Thai translation: network_unavailable_txt.
The Thai file is missing the network_unavailable_txt string key that exists in the Hindi file. When the application code calls stringResource(R.string.network_unavailable_txt) for a Thai locale user, it will throw MissingResourceException at runtime, causing the app to crash instead of displaying the network unavailability message.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@values-th/strings.xml` around lines 1 - 73, The Thai translation file
values-th/strings.xml is missing the network_unavailable_txt string resource key
which causes a MissingResourceException when the app tries to access it for Thai
locale users. Add the missing network_unavailable_txt string entry to the
values-th/strings.xml file between the XML opening tag and the closing resources
tag, using a Thai translation that conveys the message about network being
unavailable. Reference the Hindi values file to see the original
network_unavailable_txt string if needed to understand the intended meaning and
ensure consistency with the app's messaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
| Semantically changed | 3 |
| Surface changes skipped | 3 |
| Languages | 4 |
Summary by CodeRabbit