Lazy load entities when requested instead of initializing everything on load#26
Open
tomas wants to merge 31 commits into
Open
Lazy load entities when requested instead of initializing everything on load#26tomas wants to merge 31 commits into
tomas wants to merge 31 commits into
Conversation
…ies on requested instead of on initialization
…on (as part of iterable? check)
… Alias old methods nontheless
…ies (OrdersHistogram entries)
…enumerable/block behaviour
Member
Author
|
This branch also includes the retry request logic from PR #14 (with tests) |
Member
Author
|
Tests pass 100% both on Ruby 2.7.1 and 3.2.0 |
Potential memory leaks:
- Entity and Relation now hold a WeakRef to the client/strategy, so
entity graphs retained by application code (caches, sessions) no longer
prevent the Strategy, its Faraday connection pool, and auth credentials
from being garbage collected. A clear RuntimeError is raised if a link
is followed after the strategy has been GC'd.
- Configuration#logger now memoises with ||= instead of ||, preventing a
fresh Logger from being allocated on every call when no logger is set.
- Strategy no longer allocates an empty Proc.new{} when no on_new_token
block is given; on_new_token is nil and callers use &.call.
Code improvements:
- Oauth2Strategy#retryable: remove redundant begin/end wrapper.
- Replace default Faraday::HttpCache::MemoryStore (unbounded) with
BoundedMemoryStore, which evicts the oldest entry once the cache reaches
500 entries, capping in-process memory growth in long-running servers.
New features:
- Client#close: nilifies the memoised Faraday connection so it can be GC'd.
- Client accepts :timeout and :open_timeout options and forwards them to
Faraday, making request timeouts configurable without monkey-patching.
- TooManyRequestsError (HTTP 429) added to the error hierarchy so callers
can rescue rate-limit responses distinctly from other transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just realized I never submitted this PR because whatever reason. This branch is an attempt at reducing memory allocations by instantiating entities when called instead of doing as part of the response parsing process.